fix: update utf-8 encoding and decoding implementations #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRSgit
reviewed
Sep 14, 2024
FRSgit
reviewed
Sep 14, 2024
|
Hi @backrunner! Thanks for the contribution - it's great to see that you've reacted on the issue you've found! ❤️ As I wrote in another comment - I think there was a specific corner case that I handled in my code, I need to find it once again. Also, I plan to add vitest test suite on the main branch, because your case should be handled in the tests to make sure we won't make the same mistake again in the future. I'll try to add it tomorrow. And last, but not least - please run |
backrunner
force-pushed
the
patch/utf8_decode
branch
from
6d50f92 to
b7e025e
Compare
|
Nice, thanks for such great collaboration! I'm merging the PR and hope we'll e-meet each other again! 👋 |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
## [1.0.78](v1.0.77...v1.0.78) (2024-09-16) ### Bug Fixes * update utf8 encoding and decoding implementation to make it compatible with 4 bytes unicode ([#89](#89)) ([7534308](7534308))
|
🎉 This PR is included in version 1.0.78 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix: #88
The new implementations can handle the 4 bytes unicode emoji characters.