bgpd: Add disable-addpath-rx knob #9545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polychaeta
reviewed
Sep 2, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/4b5103b890026f17ba8ac075da8b87e7/raw/4eed11fa904330e3eebce5d22c10c33bd3fb0d35/cr_9545_1630615127.diff | git apply
diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h
index e3d83bd00..aba54af65 100644
--- a/bgpd/bgpd.h
+++ b/bgpd/bgpd.h
@@ -1356,7 +1356,7 @@ struct peer {
#define PEER_FLAG_SEND_LARGE_COMMUNITY (1U << 26) /* Send large Communities */
#define PEER_FLAG_MAX_PREFIX_OUT (1U << 27) /* outgoing maximum prefix */
#define PEER_FLAG_MAX_PREFIX_FORCE (1U << 28) /* maximum-prefix <num> force */
-#define PEER_FLAG_DISABLE_ADDPATH_RX (1U << 29) /* disable-addpath-rx */
+#define PEER_FLAG_DISABLE_ADDPATH_RX (1U << 29) /* disable-addpath-rx */
enum bgp_addpath_strat addpath_type[AFI_MAX][SAFI_MAX];
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18AMD64-21549/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21549/artifact/TOPO9U18AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
|
ci:rerun |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 i386 part 9: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO9U18I386-21559/test Topology Tests failed for Topotests Ubuntu 18.04 i386 part 9: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21559/artifact/TOPO9U18I386/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
ton31337
force-pushed
the
feature/disable-addpath-rx
branch
from
10a93c6 to
347be63
Compare
polychaeta
reviewed
Sep 3, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/64337f26bf4be02db7f07881659fda58/raw/4eed11fa904330e3eebce5d22c10c33bd3fb0d35/cr_9545_1630666258.diff | git apply
diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h
index e3d83bd00..aba54af65 100644
--- a/bgpd/bgpd.h
+++ b/bgpd/bgpd.h
@@ -1356,7 +1356,7 @@ struct peer {
#define PEER_FLAG_SEND_LARGE_COMMUNITY (1U << 26) /* Send large Communities */
#define PEER_FLAG_MAX_PREFIX_OUT (1U << 27) /* outgoing maximum prefix */
#define PEER_FLAG_MAX_PREFIX_FORCE (1U << 28) /* maximum-prefix <num> force */
-#define PEER_FLAG_DISABLE_ADDPATH_RX (1U << 29) /* disable-addpath-rx */
+#define PEER_FLAG_DISABLE_ADDPATH_RX (1U << 29) /* disable-addpath-rx */
enum bgp_addpath_strat addpath_type[AFI_MAX][SAFI_MAX];
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
Outdated results 💚Basic BGPD CI results: SUCCESS, 0 tests failed
For details, please contact louberger |
mjstapp
reviewed
Sep 3, 2021
The idea is to disable addpath-rx capability to avoid unnecessary additional routes installed. Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
ton31337
force-pushed
the
feature/disable-addpath-rx
branch
from
347be63 to
7cb0494
Compare
polychaeta
reviewed
Sep 3, 2021
There was a problem hiding this comment.
Thanks for your contribution to FRR!
Click for style suggestions
To apply these suggestions:
curl -s https://gist.githubusercontent.com/polychaeta/2836d5024cd40bddea06adbd13c85506/raw/d29ad86cab5b3eb535d2def82c7d80147d113bfe/cr_9545_1630670732.diff | git apply
diff --git a/bgpd/bgp_vty.c b/bgpd/bgp_vty.c
index 1d67f5560..4611be408 100644
--- a/bgpd/bgp_vty.c
+++ b/bgpd/bgp_vty.c
@@ -7969,12 +7969,9 @@ DEFUN (no_neighbor_ttl_security,
}
/* disable-addpath-rx */
-DEFUN(neighbor_disable_addpath_rx,
- neighbor_disable_addpath_rx_cmd,
+DEFUN(neighbor_disable_addpath_rx, neighbor_disable_addpath_rx_cmd,
"neighbor <A.B.C.D|X:X::X:X|WORD> disable-addpath-rx",
- NEIGHBOR_STR
- NEIGHBOR_ADDR_STR2
- "Do not accept additional paths\n")
+ NEIGHBOR_STR NEIGHBOR_ADDR_STR2 "Do not accept additional paths\n")
{
char *peer_str = argv[1]->arg;
struct peer *peer;
@@ -7989,13 +7986,9 @@ DEFUN(neighbor_disable_addpath_rx,
PEER_FLAG_DISABLE_ADDPATH_RX);
}
-DEFUN(no_neighbor_disable_addpath_rx,
- no_neighbor_disable_addpath_rx_cmd,
+DEFUN(no_neighbor_disable_addpath_rx, no_neighbor_disable_addpath_rx_cmd,
"no neighbor <A.B.C.D|X:X::X:X|WORD> disable-addpath-rx",
- NO_STR
- NEIGHBOR_STR
- NEIGHBOR_ADDR_STR2
- "Do not accept additional paths\n")
+ NO_STR NEIGHBOR_STR NEIGHBOR_ADDR_STR2 "Do not accept additional paths\n")
{
char *peer_str = argv[2]->arg;
struct peer *peer;
diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h
index ee8e51101..aba54af65 100644
--- a/bgpd/bgpd.h
+++ b/bgpd/bgpd.h
@@ -1356,7 +1356,7 @@ struct peer {
#define PEER_FLAG_SEND_LARGE_COMMUNITY (1U << 26) /* Send large Communities */
#define PEER_FLAG_MAX_PREFIX_OUT (1U << 27) /* outgoing maximum prefix */
#define PEER_FLAG_MAX_PREFIX_FORCE (1U << 28) /* maximum-prefix <num> force */
-#define PEER_FLAG_DISABLE_ADDPATH_RX (1U << 29) /* disable-addpath-rx */
+#define PEER_FLAG_DISABLE_ADDPATH_RX (1U << 29) /* disable-addpath-rx */
enum bgp_addpath_strat addpath_type[AFI_MAX][SAFI_MAX];
If you are a new contributor to FRR, please see our contributing guidelines.
After making changes, you do not need to create a new PR. You should perform an amend or interactive rebase followed by a force push.
|
@mjstapp fixed. |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
Continuous Integration Result: FAILEDContinuous Integration Result: FAILEDSee below for issues. This is a comment from an automated CI system. Get source / Pull Request: SuccessfulBuilding Stage: SuccessfulBasic Tests: FailedTopotests Ubuntu 18.04 amd64 part 7: Failed (click for details)Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPO7U18AMD64-21564/test Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 7: see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21564/artifact/TOPO7U18AMD64/ErrorLog/log_topotests.txt Successful on other platforms/tests
|
|
CI:rerun |
Continuous Integration Result: SUCCESSFULContinuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21568/ This is a comment from an automated CI system. |
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-21587/ This is a comment from an automated CI system. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.