Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zebra diet #4236

Merged
merged 6 commits into from
May 2, 2019
Merged

Zebra diet #4236

merged 6 commits into from
May 2, 2019

Conversation

donaldsharp
Copy link
Member

  1. Clean up some doc with new data structures
  2. Memory reduction of zebra at scale.

@LabN-CI
Copy link
Collaborator

LabN-CI commented May 1, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4236 db86a26
Date 05/01/2019
Start 09:05:25
Finish 09:30:19
Run-Time 24:54
Total 1816
Pass 1816
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-01-09:05:25.txt
Log autoscript-2019-05-01-09:06:38.log.bz2
Memory 446 438 374

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented May 1, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4236 fa69165
Date 05/01/2019
Start 10:15:26
Finish 10:39:48
Run-Time 24:22
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-01-10:15:26.txt
Log autoscript-2019-05-01-10:16:19.log.bz2
Memory 447 435 374

For details, please contact louberger

@LabN-CI
Copy link
Collaborator

LabN-CI commented May 1, 2019

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/4236 99b1bcd
Date 05/01/2019
Start 10:45:34
Finish 11:09:50
Run-Time 24:16
Total 1813
Pass 1813
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2019-05-01-10:45:34.txt
Log autoscript-2019-05-01-10:46:27.log.bz2
Memory 438 446 374

For details, please contact louberger

@FRRouting FRRouting deleted a comment from NetDEF-CI May 1, 2019
@LabN-CI
Copy link
Collaborator

LabN-CI commented May 1, 2019

🛑 Basic BGPD CI results: FAILURE

Results table
_ _
Result FAILURE git merge/4236 5b199f8 Crash -- 3 cores
Date 05/01/2019
Start 11:15:34
Finish 11:17:23
Run-Time 01:49
Total 182
Pass 178
Fail 4
Valgrind-Errors
Valgrind-Loss
Details vncregress-2019-05-01-11:15:34.txt
Log autoscript-2019-05-01-11:16:26.log.bz2
Memory 5044 5060 5060

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7424/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for rib.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #166: FILE: /tmp/f1-22404/rib.h:166:
Report for zebra_rib.c | 2 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #1234: FILE: /tmp/f1-22404/zebra_rib.c:1234:

CLANG Static Analyzer Summary

  • Github Pull Request 4236, comparing to Git base SHA bcbce7b

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7424/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI005BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI005BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
______ TestFlag.test_peer_ipv4_multicast_remove_private_AS_all_replace_AS ______
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
line = 'peer\\ipv4-multicast\\remove-private-AS all replace-AS'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'peer\\ipv4-multicast\\remove-private-AS all replace-AS' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
----------------------------- Captured stderr call -----------------------------
lt-test_peer_attr: lib/table.c:43: rn_hash_node_fini: Assertion `h->hh.count == 0' failed.
_______ TestFlag.test_peer_ipv4_unicast_capability_orf_prefix_list_both ________
self = <test_peer_attr.TestFlag object at 0x7f52e1d79d10>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
line = 'peer\\ipv4-unicast\\capability orf prefix-list both'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'peer\\ipv4-unicast\\capability orf prefix-list both' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
______________ TestFlag.test_peer_ipv6_multicast_maximum_prefix_4 ______________
self = <test_peer_attr.TestFlag object at 0x7f52e1d8b510>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
line = 'peer\\ipv6-multicast\\maximum-prefix'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'peer\\ipv6-multicast\\maximum-prefix' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
______________ TestFlag.test_peer_ipv6_multicast_maximum_prefix_5 ______________
self = <test_peer_attr.TestFlag object at 0x7f52e1d8bd10>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1804AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1804AMD64/ErrorLog/log_pytests.txt

Ubuntu 14.04 amd64 build: Failed (click for details) Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI001BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 14.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI001BUILD/ErrorLog/log_pytests.txt

Debian 8 amd64 build: Failed (click for details) Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI008BLD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 8 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI008BLD/ErrorLog/log_pytests.txt

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI021BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 9 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI021BUILD/ErrorLog/log_pytests.txt

OpenBSD 6 amd64 build: Failed (click for details) OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI011BUILD/ErrorLog/log_pytests.txt

NetBSD 7 amd64 build: Failed (click for details) NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI012BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for NetBSD 7 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI012BUILD/ErrorLog/log_pytests.txt

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI014BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI014BUILD/ErrorLog/log_pytests.txt

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI009BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 11 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI009BUILD/ErrorLog/log_pytests.txt

CentOS 6 amd64 build: Failed (click for details) CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI006BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI006BUILD/ErrorLog/log_pytests.txt

NetBSD 6 amd64 build: Failed (click for details) NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI007BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for NetBSD 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI007BUILD/ErrorLog/log_pytests.txt

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1604I386/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 i386 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1604I386/ErrorLog/log_pytests.txt

Successful on other platforms
  • OmniOS amd64 build
  • Ubuntu 12.04 amd64 build

Warnings Generated during build:

Checkout code: Successful with additional warnings
CentOS 7 amd64 build: Failed (click for details) CentOS 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI005BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 7 amd64 build:
(see full PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI005BUILD/ErrorLog/log_pytests.txt)

=================================== FAILURES ===================================
______ TestFlag.test_peer_ipv4_multicast_remove_private_AS_all_replace_AS ______
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
line = 'peer\\ipv4-multicast\\remove-private-AS all replace-AS'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'peer\\ipv4-multicast\\remove-private-AS all replace-AS' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
----------------------------- Captured stderr call -----------------------------
lt-test_peer_attr: lib/table.c:43: rn_hash_node_fini: Assertion `h->hh.count == 0' failed.
_______ TestFlag.test_peer_ipv4_unicast_capability_orf_prefix_list_both ________
self = <test_peer_attr.TestFlag object at 0x7f52e1d79d10>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
line = 'peer\\ipv4-unicast\\capability orf prefix-list both'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'peer\\ipv4-unicast\\capability orf prefix-list both' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
______________ TestFlag.test_peer_ipv6_multicast_maximum_prefix_4 ______________
self = <test_peer_attr.TestFlag object at 0x7f52e1d8b510>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
    self._onesimple(line)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
self = <test_peer_attr.TestFlag object at 0x7f52e1d95d50>
line = 'peer\\ipv6-multicast\\maximum-prefix'
    def _onesimple(self, line):
        if type(line) is str:
            line = line.encode('utf8')
        idx = self.output.find(line)
        if idx != -1:
            self.output = self.output[idx+len(line):]
        else:
>           raise MultiTestFailure("%r could not be found" % line)
E           MultiTestFailure: 'peer\\ipv6-multicast\\maximum-prefix' could not be found
helpers/python/frrtest.py:140: MultiTestFailure
______________ TestFlag.test_peer_ipv6_multicast_maximum_prefix_5 ______________
self = <test_peer_attr.TestFlag object at 0x7f52e1d8bd10>
    def testfunction(self):
        self._run_tests()
        result = self.testresults[matchfunction]
        if result is not None:
>           frrsix.reraise(*result)
helpers/python/frrtest.py:101: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
helpers/python/frrtest.py:76: in _run_tests
    test(self)
helpers/python/frrtest.py:94: in matchfunction
    method(self, *args, **kwargs)
helpers/python/frrtest.py:143: in _okfail
Ubuntu 18.04 amd64 build: Failed (click for details) Ubuntu 18.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1804AMD64/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 18.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1804AMD64/ErrorLog/log_pytests.txt

Ubuntu 14.04 amd64 build: Failed (click for details) Ubuntu 14.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI001BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 14.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI001BUILD/ErrorLog/log_pytests.txt

Debian 8 amd64 build: Failed (click for details) Debian 8 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI008BLD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 8 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI008BLD/ErrorLog/log_pytests.txt

Debian 9 amd64 build: Failed (click for details) Debian 9 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI021BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Debian 9 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI021BUILD/ErrorLog/log_pytests.txt

OpenBSD 6 amd64 build: Failed (click for details) OpenBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI011BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for OpenBSD 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI011BUILD/ErrorLog/log_pytests.txt

NetBSD 7 amd64 build: Failed (click for details) NetBSD 7 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI012BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for NetBSD 7 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI012BUILD/ErrorLog/log_pytests.txt

Ubuntu 16.04 amd64 build: Failed (click for details) Ubuntu 16.04 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI014BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI014BUILD/ErrorLog/log_pytests.txt

FreeBSD 11 amd64 build: Failed (click for details) FreeBSD 11 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI009BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for FreeBSD 11 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI009BUILD/ErrorLog/log_pytests.txt

CentOS 6 amd64 build: Failed (click for details) CentOS 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI006BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for CentOS 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI006BUILD/ErrorLog/log_pytests.txt

NetBSD 6 amd64 build: Failed (click for details) NetBSD 6 amd64 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI007BUILD/config.status/config.status

DejaGNU Unittests (make check) failed for NetBSD 6 amd64 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/CI007BUILD/ErrorLog/log_pytests.txt

Ubuntu 16.04 i386 build: Failed (click for details) Ubuntu 16.04 i386 build: config.status output from configure script can be found at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1604I386/config.status/config.status

DejaGNU Unittests (make check) failed for Ubuntu 16.04 i386 build
Pytest output suppressed for verbosity. See failure on other Distro above
see PyTest log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7426/artifact/U1604I386/ErrorLog/log_pytests.txt

Report for rib.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #166: FILE: /tmp/f1-21240/rib.h:166:
Report for typesafe.h | 6 issues
===============================================
< WARNING: line over 80 characters
< #278: FILE: /tmp/f1-21240/typesafe.h:278:
< WARNING: line over 80 characters
< #386: FILE: /tmp/f1-21240/typesafe.h:386:
< WARNING: line over 80 characters
< #579: FILE: /tmp/f1-21240/typesafe.h:579:
Report for zebra_rib.c | 2 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #1234: FILE: /tmp/f1-21240/zebra_rib.c:1234:

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7425/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for rib.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #166: FILE: /tmp/f1-29845/rib.h:166:
Report for typesafe.h | 6 issues
===============================================
< WARNING: line over 80 characters
< #278: FILE: /tmp/f1-29845/typesafe.h:278:
< WARNING: line over 80 characters
< #386: FILE: /tmp/f1-29845/typesafe.h:386:
< WARNING: line over 80 characters
< #579: FILE: /tmp/f1-29845/typesafe.h:579:
Report for zebra_rib.c | 2 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #1234: FILE: /tmp/f1-29845/zebra_rib.c:1234:

CLANG Static Analyzer Summary

  • Github Pull Request 4236, comparing to Git base SHA bcbce7b

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7425/artifact/shared/static_analysis/index.html

@louberger louberger mentioned this pull request May 1, 2019
Merged
donaldsharp and others added 6 commits May 1, 2019 20:28
@donaldsharp
doc: Some minor doc cleanup for new data structures
820b3b6 
Noticed during attempts at usage that the documentation
needed a couple small updates:

1) Tell the user which header to include
2) Some functions want the address of the data structure

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
zebra: Remove linked list and replace with new LIST
0a45d97 
The `struct rib_dest_t` was being used to store the linked
list of rnh's associated with the node.  This was taking up
a bunch of memory.  Replace with new data structure supplied
by David and see the memory reductions associated with 1 million
routes in the zebra rib:

Old:
Memory statistics for zebra:
System allocator statistics:
  Total heap allocated:  675 MiB
  Holding block headers: 0 bytes
  Used small blocks:     0 bytes
  Used ordinary blocks:  567 MiB
  Free small blocks:     39 MiB
  Free ordinary blocks:  69 MiB
  Ordinary blocks:       0
  Small blocks:          0
  Holding blocks:        0

New:
Memory statistics for zebra:
System allocator statistics:
  Total heap allocated:  574 MiB
  Holding block headers: 0 bytes
  Used small blocks:     0 bytes
  Used ordinary blocks:  536 MiB
  Free small blocks:     33 MiB
  Free ordinary blocks:  4600 KiB
  Ordinary blocks:       0
  Small blocks:          0
  Holding blocks:        0

`struct rnh` was moved to rib.h because of the tangled web
of structure dependancies.  This data structure is used
in numerous places so it should be ok for the moment.
Future work might be needed to do a better job of splitting
up data structures and function definitions.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
lib: Make _find functions treat the head as const
a07f484 
The head of a list should not change for find functions.  Probably
are others that should be considered but these changes can come
in as needed I believe.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
lib: Make prefix_hash_key accept a const
6701b1b 
We should not be modifying the pointer for the prefix_hash_key
function, make it a const so that we can use it elsewhere.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@donaldsharp
lib: Convert table code to use new hash type
0103534 
This converts the new table code to use the new hash
type provided by David.

The following test is 1 million routes installed and how
much memory we are using:

Old mem usage:
Memory statistics for zebra:
System allocator statistics:
  Total heap allocated:  574 MiB
  Holding block headers: 0 bytes
  Used small blocks:     0 bytes
  Used ordinary blocks:  536 MiB
  Free small blocks:     33 MiB
  Free ordinary blocks:  4600 KiB
  Ordinary blocks:       0
  Small blocks:          0
  Holding blocks:        0

New Memory usage:
Memory statistics for zebra:
System allocator statistics:
  Total heap allocated:  542 MiB
  Holding block headers: 0 bytes
  Used small blocks:     0 bytes
  Used ordinary blocks:  506 MiB
  Free small blocks:     3374 KiB
  Free ordinary blocks:  33 MiB
  Ordinary blocks:       0
  Small blocks:          0
  Holding blocks:        0

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
@louberger @donaldsharp
topotests/bgp_rfapi_basic_sanity: cleanup rfapi using non-debug command
be6f84a 
Signed-off-by: Lou Berger <lberger@labn.net>
@LabN-CI
Copy link
Collaborator

LabN-CI commented May 2, 2019

🚧 Basic BGPD CI results: Partial FAILURE, 55 tests failed, has VALGRIND issues

Results table
_ _
Result SUCCESS git merge/4236 be6f84a
Date 05/01/2019
Start 20:50:33
Finish 21:14:56
Run-Time 24:23
Total 1860
Pass 1805
Fail 55
Valgrind-Errors 0
Valgrind-Loss 6
Details vncregress-2019-05-01-20:50:33.txt
Log autoscript-2019-05-01-20:51:30.log.bz2
Memory 433 425 359

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7431/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings 
Report for rib.h | 2 issues
===============================================
< WARNING: do not add new typedefs
< #166: FILE: /tmp/f1-18798/rib.h:166:
Report for typesafe.h | 6 issues
===============================================
< WARNING: line over 80 characters
< #278: FILE: /tmp/f1-18798/typesafe.h:278:
< WARNING: line over 80 characters
< #386: FILE: /tmp/f1-18798/typesafe.h:386:
< WARNING: line over 80 characters
< #579: FILE: /tmp/f1-18798/typesafe.h:579:
Report for zebra_rib.c | 2 issues
===============================================
< WARNING: space prohibited between function name and open parenthesis '('
< #1238: FILE: /tmp/f1-18798/zebra_rib.c:1238:

CLANG Static Analyzer Summary

  • Github Pull Request 4236, comparing to Git base SHA 5390986

No Changes in Static Analysis warnings compared to base

12 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-7431/artifact/shared/static_analysis/index.html

@louberger
Copy link
Member

louberger commented May 2, 2019 •
edited
Loading

Errors are basically the same:

8.15.36 7.0.0.137 Memory leak on exit, 4 errors 0 1
8.15.37 7.0.0.137 Leaked type: Hash : 2 * (variably sized) 0 1
8.15.38 7.0.0.137 Leaked type: Hash Index : 1 * (variably sized) 0 1
8.15.39 7.0.0.137 Leaked type: Link List : 1 * 40 blocks 0 1
8.15.40 7.0.0.137 Leaked type: Link Node : 1 * 24 blocks 0 1

issue was on master...

@louberger louberger closed this May 2, 2019
@louberger louberger merged commit eefbfd1 into FRRouting:master May 2, 2019
@louberger louberger mentioned this pull request May 2, 2019
Merged
@louberger
Copy link
Member

not sure how, but merged while looking at PR on phone -- guess that was a bad idea. My apologies!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@donaldsharp @LabN-CI @NetDEF-CI @louberger @polychaeta