Fpm problems #17962
Open
Fpm problems #17962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjstapp
approved these changes
Jan 30, 2025
donaldsharp
force-pushed
the
fpm_problems
branch
from
90478c8 to
945aea6
Compare
mjstapp
reviewed
Jan 30, 2025
| ) | ||
| router.load_config( | ||
| TopoRouter.RD_SHARP, os.path.join(CWD, "{}/sharpd.conf".format(rname)) | ||
| ) | ||
| router.load_config( | ||
| TopoRouter.RD_FPM_LISTENER, | ||
| os.path.join(CWD, "{}/fpm_stub.conf".format(rname)), | ||
| "-r" |
There was a problem hiding this comment.
looks like there's a style warning about this line?
donaldsharp
force-pushed
the
fpm_problems
branch
2 times, most recently
from
c5ee28a to
1464774
Compare
|
the last commit was a serious enough of a problem that I wanted that as a bug fix in previous releases so it's in #17969 |
A recent code change 29122bc changed the passing of data up the fpm from passing the tableid and vrf to the sonic expected tableid contains the vrfid. This violates the assumptions in the code that the netlink message passes up the tableid as the tableid. Additionally this code change did not modify the rib_find_rn_from_ctx to actually properly decode what could be passed up. Let's just fix this and let Sonic carry the patch as appropriate for themselves since they are not the only users of dplane_fpm_nl.c Signed-off-by: Donald Sharp <sharpd@nvidia.com>
In fpm_listener, when a error is detected it would stop listening and not recover. Modify the code to close the socket and allow the connection to recover. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
The fpm_testing_topo1 didn't turn on the fpm_listener sending the routes back to zebra to set the asic offload. Modify the test to tell the fpm_listener to set the offloaded flag and reflect the route back to the dplane_fpm_nl.c code. Also modify zebra to expect a response to the underlying fpm listener. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
The mutex that wraps access to the output buffer is being held for the entire time the data is being generated to send down the pipe. Since the generation has absolutely nothing to do with the obuf, let's limit the mutex holding some. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When looping through the dplane providers, the worklist was being populated with items from the last provider and then the event system was checked to see if we should stop processing. If the event system says `yes` then the dplane code would stop and send the worklist to the master zebra pthread for collection. This obviously skipped the next dplane provider on the list which is double plus not good. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
donaldsharp
force-pushed
the
fpm_problems
branch
from
1464774 to
64709ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found a couple issues when attempting to recreate a different problem.