*: Add a bunch of warnings to our build system #17954
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code should compile cleanly with these new additional compiler warnings added. This is as per suggestion. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ton31337
approved these changes
Jan 29, 2025
|
Should this go in during the freeze? |
|
no |
|
This is more like to see what should we FIX? |
eqvinox
requested changes
Jan 29, 2025
| AC_C_FLAG([-Wformat-security]) | ||
| AC_C_FLAG([-Wformat=2]) | ||
| AC_C_FLAG([-Wtrampolines]) | ||
| AC_C_FLAG([-Wbdi-chars=any]) |
There was a problem hiding this comment.
typo, no such warning exists
There was a problem hiding this comment.
(there's an i missing in -Wbidi-chars)
| @@ -457,7 +457,9 @@ AC_C_FLAG([-funwind-tables]) | |||
| AC_C_FLAG([-Wall]) | |||
| AC_C_FLAG([-Wextra]) | |||
| AC_C_FLAG([-Wformat-nonliteral]) | |||
| AC_C_FLAG([-Wformat-security]) | |||
There was a problem hiding this comment.
didn't the doc say something about clang still needing -Wformat-security with -Wformat=2 or so?
| @@ -467,6 +469,11 @@ AC_C_FLAG([-Wbad-function-cast]) | |||
| AC_C_FLAG([-Wwrite-strings]) | |||
| AC_C_FLAG([-Wundef]) | |||
| AC_C_FLAG([-Wimplicit-fallthrough]) | |||
| AC_C_FLAG([-Werror=implicit]) | |||
| AC_C_FLAG([-Werror=int-conversion]) | |||
| AC_C_FLAG([-Werror=incompatible-pointer-types]) | |||
There was a problem hiding this comment.
not sure we should be putting any -Werror here considering we have the global -Werror switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code should compile cleanly with these new additional compiler warnings added. This is as per suggestion.