lib: mutexes don't need no shadow #17937
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_once` loop variable will result in a `-Wshadow` warning when that is turned on. Use `__COUNTER__` to give these variables distinct names, like is already done with `_mtx_`. (and because I touched it, clang-format wants it reformatted... ohwell.) Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
(CI build VM hung after build for some reason [after completing the build, even], killed it and kicked it to retry) |
|
ci:rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
_onceloop variable will result in a-Wshadowwarning when that is turned on. Use__COUNTER__to give these variables distinct names, like is already done with_mtx_.(and because I touched it, clang-format wants it reformatted... ohwell.)