*: preliminary fixes for -Wcast-qual
#17936
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`register` is archaic C, and rejected by C++ compilers. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
I have no idea why, but the C++ preprocessor doesn't like the GCC `, ## __VA_ARGS__` magic for eliding the comma in case there are no macro arguments... Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Not for the faint of heart, but makes `-Wcast-qual` not a total lost cause. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
Initial stab at reducing some `-Wcast-qual` warnings. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This time with `unconst()`, which is for actual casts where const needs to go away. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
This warning is entirely unhelpful for this generated code. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
|
The @frrbot suggestion to add that single space character is in disagreement with |
mjstapp
reviewed
Jan 27, 2025
Not sure what is going on here, Gentoo's 8.4 and 7.5 are both fine so I'm gonna call it Debian's mess-up. Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
eqvinox
force-pushed
the
cast-qual-foo
branch
from
70c9783 to
ca2a57a
Compare
|
Waiting for freeze period to be over |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't get anywhere close to being clean on
-Wcast-qual, but it gets the warnings down from a few hundred thousand (due to warnings in headers being shown on every single file using that header) to less than a thousand.I initially thought this isn't worth it, but albeit the
lib/compiler.hmagic is now notably longer it might actually be a bit easier to understand, so even just for that it might be worth it. (If you want to read it, I highly recommend reading the after-changes version rather than the diff.)(also contains 2 tangentially-related C++ fixes since I had to fix those to be able to try with a C++ compiler)