Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zebra: Fix resetting valid flags for NHG dependents (backport #17731) #17746

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Dec 31, 2024

Upon if_down, we don't reset the valid flag for dependents and unset the INSTALLED flag.

So when its time for the NHG to be deleted (routes dereferenced), zebra deletes it since refcnt goes to 0, but stale NHG remains in kernel.

Ticket :#4200788


This is an automatic backport of pull request #17731 done by Mergify.

Upon if_down, we don't reset the valid flag for dependents
and unset the INSTALLED flag.

So when its time for the NHG to be deleted (routes dereferenced),
zebra deletes it since refcnt goes to 0, but stale NHG remains in kernel.

Ticket :#4200788

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

Signed-off-by: Rajasekar Raja <rajasekarr@nvidia.com>
(cherry picked from commit 54ec9f3)

# Conflicts:
#	zebra/zebra_nhg.c
@mergify mergify bot added the conflicts label Dec 31, 2024
Copy link
Author

mergify bot commented Dec 31, 2024

Cherry-pick of 54ec9f3 has failed:

On branch mergify/bp/stable/8.5/pr-17731
Your branch is up to date with 'origin/stable/8.5'.

You are currently cherry-picking commit 54ec9f388.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   zebra/zebra_nhg.c

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@frrbot frrbot bot added the zebra label Dec 31, 2024
@ton31337 ton31337 closed this Dec 31, 2024
@ton31337 ton31337 deleted the mergify/bp/stable/8.5/pr-17731 branch December 31, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants