Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: Move some non BGP-specific route-map functions to lib #17059

Merged
merged 1 commit into from
Oct 11, 2024
Merged

bgpd: Move some non BGP-specific route-map functions to lib #17059

merged 1 commit into from
Oct 11, 2024
+73 −80

Conversation

ton31337
Copy link
Member

@ton31337 ton31337 commented Oct 10, 2024 •
edited
Loading

Closes #17055

@ton31337
bgpd: Move some non BGP-specific route-map functions to lib
b9a9be4 
They are managed under `frr-route-map`, not under `frr-bgp-route-map`.

Fixes: FRRouting#17055

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337
Copy link
Member Author

@Mergifyio backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

@mergify Mergify
Copy link

mergify bot commented Oct 10, 2024 •
edited
Loading

backport dev/10.2 stable/10.1 stable/10.0 stable/9.1 stable/9.0

✅ Backports have been created

@donaldsharp
Copy link
Member

can we update the routemap documentation? Do we need to actually check that this works for other daemons now?

@ton31337
Copy link
Member Author

Actually here is nothing to update because it's not a functional change. This command was and is only for bgp, only install_command was moved to lib (according to yang model). route_map_install_match is left as it was - only for bgp.

@ton31337 ton31337 added this to the 10.2 milestone Oct 11, 2024
@donaldsharp donaldsharp merged commit adc0f00 into FRRouting:master Oct 11, 2024
16 checks passed
This was referenced Oct 11, 2024
Merged
Merged
Merged
Merged
Merged
donaldsharp added a commit that referenced this pull request Oct 11, 2024
@donaldsharp
Merge pull request #17070 from FRRouting/mergify/bp/stable/9.0/pr-17059
33f45ce 
bgpd: Move some non BGP-specific route-map functions to lib (backport #17059)
donaldsharp added a commit that referenced this pull request Oct 11, 2024
@donaldsharp
Merge pull request #17069 from FRRouting/mergify/bp/stable/9.1/pr-17059
165d1a2 
bgpd: Move some non BGP-specific route-map functions to lib (backport #17059)
donaldsharp added a commit that referenced this pull request Oct 11, 2024
@donaldsharp
Merge pull request #17068 from FRRouting/mergify/bp/stable/10.0/pr-17059
a2d4087 
bgpd: Move some non BGP-specific route-map functions to lib (backport #17059)
donaldsharp added a commit that referenced this pull request Oct 11, 2024
@donaldsharp
Merge pull request #17067 from FRRouting/mergify/bp/stable/10.1/pr-17059
02e556b 
bgpd: Move some non BGP-specific route-map functions to lib (backport #17059)
donaldsharp added a commit that referenced this pull request Oct 11, 2024
@donaldsharp
Merge pull request #17066 from FRRouting/mergify/bp/dev/10.2/pr-17059
177c6d2 
bgpd: Move some non BGP-specific route-map functions to lib (backport #17059)
@ton31337 ton31337 deleted the fix/move_match_ipv6_next-hop_acl_to_routemap_lib branch October 15, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport bgp bugfix master size/L
Projects
None yet
Milestone
10.2
Development

Successfully merging this pull request may close these issues.

Assigning an access list to a route map with the "nexthop" parameter forces the activation of BGP
2 participants
@ton31337 @donaldsharp