IS-IS: Unknown command when removing domain-password and area-password

[c-po]

Description

When removing area-password or domain-password from ISIS using frr-reload it will error out

Version

stable/10.2
9e3f285

How to reproduce

Configure ISIS

!
router isis VyOS
 net 49.0001.1921.6800.1002.00
 area-password clear foo
 domain-password clear foo
exit
!

unconfigure area-password using frr-reload

cpo@LR1.wue3:~$ cat  no-area-pwd-isis.txt
!
router isis VyOS
 net 49.0001.1921.6800.1002.00
 domain-password clear foo
exit
!

sudo /usr/lib/frr/frr-reload.py --reload --debug --stdout no-area-pwd-isis.txt
...
2024-12-26 14:23:09,094   ERROR: Failed to execute router isis VyOS  no area-password clear foo exit
2024-12-26 14:23:09,094   ERROR: "router isis VyOS --  no area-password clear foo -- exit" we failed to remove this command
2024-12-26 14:23:09,094   ERROR: % Unknown command:  no area-password clear foo

Same also applies to domain-password

cpo@LR1.wue3:~$ cat no-domain-pwd-isis.txt
!
router isis VyOS
 net 49.0001.1921.6800.1002.00
 area-password clear foo
exit
!

cpo@LR1.wue3:~$ sudo /usr/lib/frr/frr-reload.py --reload --debug --stdout no-domain-pwd-isis.txt
...
2024-12-26 14:24:10,940   ERROR: Failed to execute router isis VyOS  no domain-password clear foo exit
2024-12-26 14:24:10,940   ERROR: "router isis VyOS --  no domain-password clear foo -- exit" we failed to remove this command
2024-12-26 14:24:10,940   ERROR: % Unknown command:  no domain-password clear foo
...

Expected behavior

No error

Actual behavior

% Unknown command: no  area-password clear
% Unknown command: no  area-password clear foo

Additional context

Same error can be observed from vtysh

LR1.wue3(config)# do sh run
Building configuration...

Current configuration:
!
frr version 10.2
frr defaults traditional
hostname LR1.wue3
service integrated-vtysh-config
!
router isis VyOS
 net 49.0001.1921.6800.1002.00
 area-password clear foo
 domain-password clear foo
exit
!
end
LR1.wue3(config)# router isis VyOS
LR1.wue3(config-router)# no  area-password clear
% Unknown command: no  area-password clear
LR1.wue3(config-router)# no  area-password clear foo
% Unknown command: no  area-password clear foo
LR1.wue3(config-router)#

Checklist

• I have searched the open issues for this bug.
• I have not included sensitive information in this report.

[ton31337]

Could you try this fix #17725?

[c-po]

Could you try this fix #17725?

Thank you @ton31337 for the propesed fix. Unfortunately it only works half way:

LR1.wue3(config)# router isis VyOS
LR1.wue3(config-router)# no  area-password clear
% Command incomplete: no  area-password clear
LR1.wue3(config-router)# no  area-password clear foo
LR1.wue3(config-router)# no domain-password clear
% Command incomplete: no domain-password clear
LR1.wue3(config-router)# no domain-password clear bar
LR1.wue3(config-router)#

[ton31337]

But in what case do you need a partial no form for these commands? E.g. domain-password clear can't be without an argument.

[c-po]

But in what case do you need a partial no form for these commands? E.g. domain-password clear can't be without an argument.

You're right. I also verified frr-reload behavior. It's now working as expected.

Thanks for the quick fix.