turn on the CEL when the engine is stopped

FOME-Tech · Jan 8, 2025 · 2268520 · 2268520
1 parent 8f29a48
commit 2268520
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 20 deletions.
diff --git a/firmware/CHANGELOG.md b/firmware/CHANGELOG.md
@@ -36,6 +36,7 @@ or
 ### Added
  - Support Miata NA CAS "CMP" signal as a cam input (if you've installed a 36-1 crank trigger on an NA, for example) #495
  - Support 4 independent wideband O2 channels, and 4 fuel trim banks
+ - Flash error codes for some sensors using the check engine light #526
 
 ### Fixed
  - Idle VE table's indicator dot properly tracks when using an idle VE Y-axis override

diff --git a/firmware/controllers/gauges/malfunction_indicator.cpp b/firmware/controllers/gauges/malfunction_indicator.cpp
@@ -84,20 +84,19 @@ class MILController : public PeriodicController<UTILITY_THREAD_STACK_SIZE> {
 
 		validateStack("MIL", ObdCode::STACK_USAGE_MIL, 128);
 #if EFI_SHAFT_POSITION_INPUT
-		if (nowNt - engine->triggerCentral.triggerState.mostRecentSyncTime < MS2NT(500)) {
-			enginePins.checkEnginePin.setValue(1);
-			chThdSleepMilliseconds(500);
-			enginePins.checkEnginePin.setValue(0);
-		}
-
 		static error_codes_set_s localErrorCopy;
 		// todo: why do I not see this on a real vehicle? is this whole blinking logic not used?
 		getErrorCodes(&localErrorCopy);
 
-		for (int p = 0; p < localErrorCopy.count; p++) {
-			// Calculate how many digits in this integer and display error code from start to end
-			int code = (int)localErrorCopy.error_codes[p];
-			DisplayErrorCode(DigitLength(code), code);
+		if (localErrorCopy.count) {
+			for (int p = 0; p < localErrorCopy.count; p++) {
+				// Calculate how many digits in this integer and display error code from start to end
+				int code = (int)localErrorCopy.error_codes[p];
+				DisplayErrorCode(DigitLength(code), code);
+			}
+		} else {
+			// Turn on the CEL while the engine is stopped
+			enginePins.checkEnginePin.setValue(!engine->rpmCalculator.isRunning());
 		}
 #endif // EFI_SHAFT_POSITION_INPUT
 	}

diff --git a/firmware/controllers/trigger/trigger_decoder.cpp b/firmware/controllers/trigger/trigger_decoder.cpp
@@ -39,15 +39,6 @@ bool TriggerDecoderBase::getShaftSynchronized() {
 }
 
 void TriggerDecoderBase::setShaftSynchronized(bool value) {
-	if (value) {
-		if (!shaft_is_synchronized) {
-			// just got synchronized
-			mostRecentSyncTime = getTimeNowNt();
-		}
-	} else {
-		// sync loss
-		mostRecentSyncTime = {};
-	}
 	shaft_is_synchronized = value;
 }
 

diff --git a/firmware/controllers/trigger/trigger_decoder.h b/firmware/controllers/trigger/trigger_decoder.h
@@ -125,7 +125,6 @@ class TriggerDecoderBase : public trigger_state_s {
 	 * TRUE if we know where we are
 	 */
 	bool shaft_is_synchronized;
-	efitick_t mostRecentSyncTime;
 
 	Timer previousEventTimer;