-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chainable config files #692
Conversation
Test failing on #693 issues against the test tenant, seemingly unrelated to this PR. |
@ClintonWB-EBSCO Can you go ahead and rebase your branch to main? That should fix the test failures. |
c57416e
to
c13c3a5
Compare
Codecov Report
@@ Coverage Diff @@
## main #692 +/- ##
==========================================
+ Coverage 70.90% 71.83% +0.93%
==========================================
Files 101 103 +2
Lines 11086 11264 +178
Branches 1337 1354 +17
==========================================
+ Hits 7861 8092 +231
+ Misses 2931 2878 -53
Partials 294 294
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2e2d9ec
to
f6198aa
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Resolves #682
PR to replace the single-file config load with a chainable config load.
New loader works on a pretty simple premise; at each depth, attempts to:
dict
ondict
, merge at any keylist
onlist
, merge items with matchingname
,file_name
, orfileName