Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chainable config files #692

Merged
merged 23 commits into from
Oct 24, 2023
Merged

Chainable config files #692

merged 23 commits into from
Oct 24, 2023

Conversation

ClintonWB-EBSCO
Copy link
Member

Resolves #682

PR to replace the single-file config load with a chainable config load.

New loader works on a pretty simple premise; at each depth, attempts to:

  • For dict on dict, merge at any key
  • For list on list, merge items with matching name, file_name, or fileName
  • For other values/mismatch, overwrite with new value

@ClintonWB-EBSCO
Copy link
Member Author

Test failing on #693 issues against the test tenant, seemingly unrelated to this PR.

@bltravis
Copy link
Collaborator

@ClintonWB-EBSCO Can you go ahead and rebase your branch to main? That should fix the test failures.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

Merging #692 (a7a9532) into main (39c4b5d) will increase coverage by 0.93%.
The diff coverage is 99.54%.

@@            Coverage Diff             @@
##             main     #692      +/-   ##
==========================================
+ Coverage   70.90%   71.83%   +0.93%     
==========================================
  Files         101      103       +2     
  Lines       11086    11264     +178     
  Branches     1337     1354      +17     
==========================================
+ Hits         7861     8092     +231     
+ Misses       2931     2878      -53     
  Partials      294      294              
Flag Coverage Δ
unittests 71.83% <99.54%> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/folio_migration_tools/__main__.py 96.77% <100.00%> (+58.73%) ⬆️
src/folio_migration_tools/config_file_load.py 100.00% <100.00%> (ø)
tests/test_config_file_load.py 100.00% <100.00%> (ø)
tests/test_main.py 100.00% <100.00%> (ø)
...ation_tools/migration_tasks/migration_task_base.py 31.63% <0.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@bltravis bltravis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

tests/test_main.py Show resolved Hide resolved
tests/test_main.py Show resolved Hide resolved
tests/test_main.py Show resolved Hide resolved
@bltravis bltravis merged commit e3446bd into main Oct 24, 2023
5 checks passed
@bltravis bltravis deleted the feature/chainable-config-files branch October 24, 2023 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration Configuration File Inheritance
2 participants