Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make validation of required properties work for arrays containing objects/arrays #531

Closed
branchedelac opened this issue Feb 24, 2023 · 2 comments · Fixed by #567
Closed

Make validation of required properties work for arrays containing objects/arrays #531

branchedelac opened this issue Feb 24, 2023 · 2 comments · Fixed by #567
Assignees
@branchedelac
Labels
bug Something isn't working

Comments

@branchedelac
Copy link
Contributor

See comment in: #502

"I am also noticing some oddness wrt validating required properties for more deeply nested objects (the required properties of on the middle level are forgotten when you go a level deeper, before the actual validation occurs). But I don't want to dig to deep knowing that the method has already changed."

I am seeing issues in
Organization > Contacts
Organization > Interfaces >interfaceCredentials
@branchedelac
Copy link
Contributor Author

branchedelac commented Feb 27, 2023 •
edited
Loading

This issue is a very specific sub-issue of #464.

@branchedelac branchedelac changed the title Make validation of required properties work on deeper levels Make validation of required properties work for arrays containing objects/arrays Feb 27, 2023
@branchedelac branchedelac mentioned this issue Feb 27, 2023
Closed
@branchedelac branchedelac self-assigned this Mar 3, 2023
@branchedelac branchedelac added the bug Something isn't working label Mar 24, 2023
@branchedelac
Copy link
Contributor Author

Out of scope/not centrally handled: objects in objects in arrays.

@branchedelac branchedelac linked a pull request Mar 27, 2023 that will close this issue
531 make validation of required properties work for arrays containing objectsarrays close #531 #567
Merged
branchedelac added a commit that referenced this issue Mar 29, 2023
@branchedelac
Merge pull request #567 from FOLIO-FSE/531-make-validation-of-require…
5fd8f28 
…d-properties-work-for-arrays-containing-objectsarrays

531 make validation of required properties work for arrays containing objectsarrays close #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@branchedelac branchedelac

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@branchedelac