Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin bookmarks buttons to the vine category buttons #87

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Vaskivskyi
Copy link
Contributor

This PR will pin the bookmarks buttons (now, -12 h, -24 h) to the Vine category buttons instead of the search bar.

The current issue is that the buttons are pinned to the search bar (as per the wiki). Unfortunately, not all countries have the search feature at all. As a result - there was nothing to pin to (no corresponding element in the page code) and this feature of the extension was not available at all e.g. in Germany). With this small change, the feature should be available for all the users.

image

@FMaz008
Copy link
Owner

FMaz008 commented Apr 1, 2024

Very good point, but how does it rendee with mobile stylesheets?

@Vaskivskyi
Copy link
Contributor Author

Looks fine to me for Germany

image

Worth checking when a search bar is available (e.g. in the US) - I don't know how would it work there

@FMaz008
Copy link
Owner

FMaz008 commented Apr 1, 2024

That's not the mobile stylesheet (look in the settings, style tab).

I'm on my phone atm, driving back home. I'll check this evening.

So long as it play well with the mobile stylesheet it should be good to go, but we might want to tune up the positionning a big better (left align maybe)

@FMaz008 FMaz008 merged commit 7565b50 into FMaz008:main Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants