Skip to content

Commit

Permalink
Explicitely make the is_parent_asin value a string for the URLs
Browse files Browse the repository at this point in the history
  • Loading branch information
FMaz008 committed Oct 16, 2024
1 parent c37ffbd commit 137d30c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion page/notifications.js
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ function addItem(data) {
if (Settings.get("general.searchOpenModal") && is_parent_asin != null && enrollment_guid != null) {
Tpl.setVar(
"url",
`https://www.amazon.${vineDomain}/vine/vine-items?queue=encore#openModal;${asin};${queue};${is_parent_asin};${enrollment_guid}`
`https://www.amazon.${vineDomain}/vine/vine-items?queue=encore#openModal;${asin};${queue};${is_parent_asin ? "true" : "false"};${enrollment_guid}`
);
} else {
Tpl.setVar("url", `https://www.amazon.${vineDomain}/vine/vine-items?search=${search}`);
Expand Down
2 changes: 1 addition & 1 deletion scripts/bootloader.js
Original file line number Diff line number Diff line change
Expand Up @@ -1029,7 +1029,7 @@ browser.runtime.onMessage.addListener(async function (message, sender, sendRespo
if (Settings.get("general.searchOpenModal") && is_parent_asin != null && enrollment_guid != null) {
Tpl.setVar(
"url",
`https://www.amazon.${vineDomain}/vine/vine-items?queue=encore#openModal;${asin};${queue};${is_parent_asin};${enrollment_guid}`
`https://www.amazon.${vineDomain}/vine/vine-items?queue=encore#openModal;${asin};${queue};${is_parent_asin ? "true" : "false"};${enrollment_guid}`
);
} else {
Tpl.setVar("url", `https://www.amazon.${vineDomain}/vine/vine-items?search=${search}`);
Expand Down
2 changes: 1 addition & 1 deletion scripts/vh_service_worker.js
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ chrome.notifications.onClicked.addListener((notificationId) => {
const { asin, queue, is_parent_asin, enrollment_guid, search } = notificationsData[notificationId];
if (Settings.get("general.searchOpenModal") && is_parent_asin != null && enrollment_guid != null) {
chrome.tabs.create({
url: `https://www.amazon.${vineDomain}/vine/vine-items?queue=encore#openModal;${asin};${queue};${is_parent_asin};${enrollment_guid}`,
url: `https://www.amazon.${vineDomain}/vine/vine-items?queue=encore#openModal;${asin};${queue};${is_parent_asin ? "true" : "false"};${enrollment_guid}`,
});
} else {
chrome.tabs.create({
Expand Down

0 comments on commit 137d30c

Please sign in to comment.