-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not install required pip packages on behalf of users #935
Conversation
c4c1a83
to
ea487bc
Compare
Using a fresh venv on my ubuntu system, which doesn't contain
After installing via |
fe1f749
to
2aa8cf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible.
Would we benefit from a requirements.txt
or similar?
We could, but things like Individual examples might then have additional dependencies, including I'm inclined to leave it for the future (though it might not hurt to open an issue?) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a brief sentence in README.md about where cmake will search for python and that cmake can be run from inside a virtual environment with the dependencies installed. Seems like this PR would be a good place for this to go in as its adding python discrepancies.
2aa8cf3
to
ca4a9e8
Compare
Wheel, setuptools and optionall venv are requred. Installing into --user automatically would fail in some cases, and installing not into user into a not-generated venv is bad form. Closes #639
This is not an ideal location, but the best option without more signifcant change to the readme
ca4a9e8
to
cdd2be5
Compare
Emit a CMake Fatal Error during configuraition for missing required python packages, rather than installing them into the users environment.
Wheel, setuptools and optionall venv are requred.
Installing into --user automatically would fail in some cases, and installing not into user into a not-generated venv is bad form.
Closes #639
Also switches from the deprectaed
setup.py install
to usebuild --wheel
.Closes #947.