-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swig array element unify #916
Conversation
385a255
to
683ebc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look fine, though it's unclear why PanelVis.cpp is marked as new file in the diff for this PR given it's merging into imgui
.
Good test additions too, though neither built nor ran them myself.
Possibly a GH bug, I vaguely recall I initially made this PR point at master and had to update it. |
Does seem it, a local diff for that file shows it's the same in the two branches, so who knows if I've even reviewed the right changes or even all of them....
|
…environment properties. User's are provided the ability to add environment properties/environment array property elements to user interface panel(s) in the form of input boxes, sliders, drag things and checkboxes. Additionally, moved the debug menu to ImGui and added the initial random seed to it's items.
This makes it more consistent with rest of ModelVis methods.
Also unified model naming of examples (in particular Circles Spatial3D was listed as bruteforce).
…ty() element version Also unified API of all other array element methods to have optional 2nd length arg (C++ API). Closes #912
683ebc0
to
a04688c
Compare
Have tested C++/Py tests.
Added new Py tests for the missing
CUDASimulation
functionality.Only test failures were in CodeGen, due to #915