Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 2.0.0-rc1 #1159

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Changelog for 2.0.0-rc1 #1159

merged 1 commit into from
Jan 12, 2024

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Dec 12, 2023

todo

  • Add any changes for commits ahead of this PR
  • Update release date in changelog.md/citation.cff
  • Update visualisation repo to a new release tag.

Waiting for these PRs before release: #1150, #1155. Defferred to the next release as these are blocked.

@ptheywood
Copy link
Member

This should be rc1 not rc2. Python's rc implicitly means rc0 (see previous release' assets)

CHANGELOG.md Outdated Show resolved Hide resolved
CITATION.cff Outdated Show resolved Hide resolved
@Robadob Robadob changed the title Draft Changelog for 2.0.0-rc2 Draft Changelog for 2.0.0-rc1 Dec 14, 2023
@ptheywood
Copy link
Member

ptheywood commented Dec 16, 2023

Edited the original commit to include merged but not yet included PR's / issues that will need including.

We could potentially do a pre-release with the current changes IMO, as we are blocked on the 2 outstanding ones we want before the "full" release.

I.e.

  • 2.0.0-rc1 with current changes - adds a cuda 12.x pre-release
  • 2.0.0-rc2 which removes < CUDA 11.2, and fixes jitify compialation time. Maybe CMake 3.27 Deprecation warnings (dependencies) #1156 as well.
  • 2.0.0 - assuming no problems with rc1/rc2 changes after a period of time / see how conda goes.

@ptheywood ptheywood changed the title Draft Changelog for 2.0.0-rc1 Changelog for 2.0.0-rc1 Jan 8, 2024
@ptheywood
Copy link
Member

ptheywood commented Jan 12, 2024

Manually invoked the thorough CI againt this branch as of 1c5d2e3 to check for any issues which might prevent the rc1 release from working.

https://github.com/FLAMEGPU/FLAMEGPU2/actions/runs/7502099207

If this is succcessful, then rc1 can proceeed:

  • create matching flamegpu2-visualiser release (flamegpu-2.0.0-rc.1)
  • update flamegpu2-visualiser version to fetch (flamegpu-2.0.0-rc.1)
  • Update dates of the planned release
  • Merge this PR, push the release tag (v2.0.0-rc.1)
  • Write the release notes while CI runs (~1-2 hours).
    • Include breaking changes, additions, link to the changelog, pyflamegpu installation instructions.
  • Publish the release with release notes.
  • Create the version bump PR, which needs to be the first thing merged post release tag.

@ptheywood ptheywood marked this pull request as ready for review January 12, 2024 15:09
@ptheywood
Copy link
Member

double checked that tests still path, py and c++ on linux (CUDA 12.0)

Co-authored-by: Peter Heywood <p.heywood@sheffield.ac.uk>
@ptheywood ptheywood merged commit ce1da8f into master Jan 12, 2024
20 checks passed
@ptheywood ptheywood deleted the changelog branch January 12, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants