Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CUDA 12.3 on CI, add 12.2.x URLS to windows known downloads #1130

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Use CUDA 12.3 on CI, add 12.2.x URLS to windows known downloads #1130

merged 1 commit into from
Oct 20, 2023

Conversation

ptheywood
Copy link
Member

@ptheywood ptheywood commented Oct 20, 2023 •
edited
Loading

Builds with no warnings locally using 12.3.

C++ test suite passes 1086 tests in 748s.

Python passed 650 tests in 1657 seconds, only taking 3.4s when RTC is cached, so #1118 is still relevant with 12.3.

@ptheywood ptheywood marked this pull request as ready for review October 20, 2023 15:15
Robadob
Robadob approved these changes Oct 20, 2023
View reviewed changes
Copy link
Member

@Robadob Robadob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passed, changes look pretty standard.

@Robadob Robadob merged commit 89d9302 into master Oct 20, 2023
10 checks passed
@Robadob Robadob deleted the cuda-12-3 branch October 20, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Robadob Robadob Robadob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptheywood @Robadob