Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python tests for DeviceAgentVector #1000

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Python tests for DeviceAgentVector #1000

merged 1 commit into from
Nov 30, 2022

Conversation

Robadob
Copy link
Member

@Robadob Robadob commented Nov 25, 2022

This is based on callback branch which exists in #997, as that PR fixes a bug that was blocking one of the tests.

Most appropriate tests have been ported from the C test suite, some have been removed where Python implementation of vector differs (e.g. begin()/insert() etc).
Closes #557

I also fixed a typographic issue in the C test suite. I haven't bothered to build/run that, as the fixed Python equivalent works.

Windows/Debug

(venv) C:\Users\Robadob\fgpu2\tests\swig\python>py.test pop/test_device_agent_vector.py
================================================= test session starts =================================================
platform win32 -- Python 3.9.12, pytest-7.2.0, pluggy-1.0.0
rootdir: C:\Users\Robadob\fgpu2\tests\swig\python
collected 21 items

pop\test_device_agent_vector.py .....................                                                            [100%]

================================================= 21 passed in 0.56s ==================================================

@Robadob Robadob self-assigned this Nov 25, 2022
@Robadob Robadob changed the base branch from master to callback November 28, 2022 14:39
@Robadob Robadob force-pushed the py_test_dav branch 2 times, most recently from 090fc7d to 6799c51 Compare November 28, 2022 17:06
@Robadob Robadob marked this pull request as ready for review November 28, 2022 17:07
Most appropriate tests have been ported from the C test suite, some have been removed where Python implementation of vector differs (e.g. begin()/insert() etc).
Closes #557
Copy link
Member

@ptheywood ptheywood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but not tested.

@mondus mondus merged commit d96654f into callback Nov 30, 2022
@mondus mondus deleted the py_test_dav branch November 30, 2022 15:29
Robadob added a commit that referenced this pull request Dec 7, 2022
Most appropriate tests have been ported from the C test suite, some have been removed where Python implementation of vector differs (e.g. begin()/insert() etc).
Closes #557
Robadob added a commit that referenced this pull request Dec 7, 2022
Most appropriate tests have been ported from the C test suite, some have been removed where Python implementation of vector differs (e.g. begin()/insert() etc).
Closes #557
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeviceAgentVector Py Tests
3 participants