set default value of some WsConfig fields to 0 #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-3.7.0 #222 +/- ##
==============================================
Coverage 27.97% 27.97%
==============================================
Files 8 8
Lines 2177 2177
Branches 1348 1348
==============================================
Hits 609 609
Misses 1044 1044
Partials 524 524
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bxq2011hust
approved these changes
Mar 12, 2024
bxq2011hust
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the cpu cost bug by comparing bcos_sdk_create() and bcos_sdk_create_by_config_file(). the solution is just make bcos_sdk_c_config_create_empty() return zero value instread of -1 which will translate into max uint32_t in WsConfig. It wil trigger boost::asio::deadline_timer some bug? I just solve the bug , but not know why actually. If you could tell me the reason, I would greatly appreciate it.