Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update upload-artifact action to v4 #4297

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

pmatos
Copy link
Collaborator

@pmatos pmatos commented Jan 23, 2025

No description provided.

@MelodicAlbuild
Copy link

looking good, to annotate what I brought up in discord, would be worthwhile to force a rerun of the checks to ensure they pass a second time because of the changes from v3 -> v4

@pmatos
Copy link
Collaborator Author

pmatos commented Jan 23, 2025

looking good, to annotate what I brought up in discord, would be worthwhile to force a rerun of the checks to ensure they pass a second time because of the changes from v3 -> v4

Don't think I can force a second run. Maybe @Sonicadvance1 can do that on his side since he runs the builders.

Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, second run will happen when it's merged to main.

@Sonicadvance1 Sonicadvance1 merged commit e9bd037 into FEX-Emu:main Jan 23, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants