Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x87 fst/fld optimization for different addrmodes #4266

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

pmatos
Copy link
Collaborator

@pmatos pmatos commented Jan 10, 2025

Includes tests and instcountci files and tests.
When the x87 optimizations were implement, we missed optimizing different addressing modes. This commit addresses this issue.

Discussed in #4252 .

@pmatos pmatos marked this pull request as draft January 10, 2025 14:12
@pmatos pmatos force-pushed the FSTOpt branch 2 times, most recently from a4865f5 to 6938e1f Compare January 14, 2025 12:05
@pmatos pmatos marked this pull request as ready for review January 14, 2025 12:06
@pmatos
Copy link
Collaborator Author

pmatos commented Jan 14, 2025

Argh - still generating things like this:

        "add x21, x4, #0x0 (0)",
        "st1h {z2.h}, p2, [x21]",

@pmatos pmatos marked this pull request as draft January 14, 2025 13:04
Includes tests and instcountci files and tests.
When the x87 optimizations were implement, we missed
optimizing different addressing modes. This commit addresses this issue.

Discussed in FEX-Emu#4252.
@pmatos
Copy link
Collaborator Author

pmatos commented Jan 14, 2025

OK - I think this is ready to review. Marking it as such.

@pmatos pmatos marked this pull request as ready for review January 14, 2025 15:22
@Sonicadvance1 Sonicadvance1 merged commit 3f788eb into FEX-Emu:main Jan 17, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants