Remove some x86 leftovers #3583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The "host" option was used for x86 hosts only, since they are not supported it might as well go.
x86 is not supported, so the readme shouldn't claim that it is supported
alyssarosenzweig
approved these changes
Apr 15, 2024
|
This breaks the hostrunner which our CI does still use. |
|
Closing since this fundamentally breaks some of our testing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know the x86 hosts are no longer supported, there is an x86 specific option (that crashes FEX on x86 with
terminate called after throwing an instance of 'std::bad_function_call') and an old description in readme. This PR cleans it up a bit.The CONFIG_IRJIT isn't completely removed, but I actually think that it could be removed. That will mean removing the CustomCPUFactory concept (I guess) which might not be ideal. For now removing an option to use the unused choice might be okay.
I also noticed that there are some _M_X86_64 defines that hide x86 specific code, should they go as well? Or maybe everything that isn't in FEXCore should keep the #ifdef _M_X86_64?