Feat/oasis corners 3rd try #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanStreffing
changed the title
|
WIP, found that single element islands are not correctly represented in the nodal polygon for oasis: pyfesom plot: plot of polygons for oasis: |
JanStreffing
changed the title
|
Fixed the single element island issues. Still some strange behavior after generating coupling fluxes: |
JanStreffing
changed the title
JanStreffing
changed the title
|
Fixed strange coastlines and passed coupled simulation. Ready for merge from my side. |
koldunovn
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues at the dateline and coastline. Computes a new center based on corner mean at the coastline. Purpose: the calculation of the angles of the polygon of the nodal control volume, including the Nodal center itself.
Future TODO: rewrite logic in cartesian coordinates for higher accuracy.