Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activated coupling of ice_temp & ice_alb with IFS #321

Merged
merged 2 commits into from
Apr 11, 2022
Merged

activated coupling of ice_temp & ice_alb with IFS #321

merged 2 commits into from
Apr 11, 2022

Conversation

dsidoren
Copy link
Collaborator

trackow
trackow reviewed Mar 16, 2022
View reviewed changes
Copy link
Contributor

@trackow trackow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in gen_forcing_couple.F90 is not related to the coupling of ice temp and albedo, is it? But I also think the __ifsinterface is not needed there.

Is ice_temp and ice_alb always computed? I would have expected an __oifs flag somewhere where a || __ifsinterface statement would need to be added...

@dsidoren
Copy link
Collaborator Author

The change in gen_forcing_couple.F90 is not related to the coupling of ice temp and albedo, is it? But I also think the __ifsinterface is not needed there.

right it is not related. everything with __oasis is not related to IFS. there was an __oasis directive above so the whole piece was deactivates in any case.

Is ice_temp and ice_alb always computed? I would have expected an __oifs flag somewhere where a || __ifsinterface statement would need to be added...

we will include the piece with computation from FESOM&OIFS (it is only in the master branch currently). all directives __ifsinterface are complete as far as I could see.

@trackow
Copy link
Contributor

trackow commented Mar 16, 2022

Okay, that answers everything. From my side it can go in

@koldunovn koldunovn merged commit 925c546 into refactoring Apr 11, 2022
wiltonloch pushed a commit to wiltonloch/fesom2 that referenced this pull request Feb 1, 2023
@koldunovn
Merge pull request FESOM#321 from FESOM/IFS_coupling
c23cc26 
activated coupling of ice_temp & ice_alb with IFS
@suvarchal suvarchal deleted the IFS_coupling branch December 13, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trackow trackow trackow left review comments

@koldunovn koldunovn koldunovn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsidoren @trackow @koldunovn