Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Turbo C 2.01 get and decrypt #130

Merged
merged 2 commits into from
Dec 28, 2024

Conversation

andrewbird
Copy link
Contributor

@PerditionC I see this GPG encrypted file method as a proof of concept, it works but is far from ideal. I really want all PRs to be checked with Turbo C 2.01, not just those users that have access to the passphrase (you can find that in https://github.com/FDOS/freecom/settings/secrets/actions to copy to your own repo). For this to happen the TC201.tar unencrypted file needs to be hosted somewhere else public.

Note: add the secret TC201_SYMMETRIC_PASSPHRASE to your own freecom github repository secrets to get your PRs built with Turbo C, otherwise they will only be checked fully after they have been merged.

@PerditionC
Copy link
Contributor

The download url should be a variable?, that way a forked repository can set the secret and url for hosting their own encrypted archive of the compiler to use. Doesn't help people without access to a public host or the compiler, but potentially allows more users to run the compiler before merging. Also, I think it would be better to have the secret at the FDOS organization level?, so all repositories can use the compiler, not just FreeCOM. Unfortunately, this looks like the best option as the only other I can think of would be to make a download that could be used to infringe and I'm not willing to do that.

@andrewbird
Copy link
Contributor Author

Also, I think it would be better to have the secret at the FDOS organization level?, so all repositories can use the compiler, not just FreeCOM.

Yes I would have done that, but I don't possess the organisation CI/CD Admin role so it's greyed out for me.

The download url should be a variable?, that way a forked repository can set the secret and url for hosting their own encrypted archive of the compiler to use.

Yes it could be github variable too. I'll rework that too.

Thanks

@andrewbird
Copy link
Contributor Author

Thanks for the new role, I've added two new vars for archive location and filename. I've also renamed the passphrase secret in line with the others. If the archive path/name is now set and the passphrase is not, the script will try to unpack the file as is. That way if others want to host an unencrypted tarfile they can.

Notes:
  1/ Set the Github Actions variables as follows
      a) TC201_ARCHIVE_PATHNAME to the URL without final component.
      b) TC201_ARCHIVE_FILENAME to the name of the file to be downloaded.
  2/ If the archive is GPG symmetrically encrypted set the following
    secret to your own freecom Github repository secrets to get your PRs
    built with Turbo C, otherwise they will only be checked fully
    **after** they have been merged.
      a) TC201_ARCHIVE_PASSPHRASE to the decryption passphrase.
@andrewbird andrewbird marked this pull request as ready for review December 28, 2024 13:29
@PerditionC PerditionC merged commit d369b47 into FDOS:master Dec 28, 2024
2 checks passed
@andrewbird andrewbird deleted the tc-build-fixes-02 branch December 29, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants