Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example fix #102

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Example fix #102

merged 2 commits into from
Dec 3, 2024

Conversation

lukaspie
Copy link
Collaborator

@lukaspie lukaspie commented Dec 3, 2024

Summary by Sourcery

Enhancements:

  • Add 'quantities' field to the xps.scheme.archive.yaml file.

Copy link

sourcery-ai bot commented Dec 3, 2024

Reviewer's Guide by Sourcery

This PR makes a minor structural correction in the YAML schema definition by moving the 'title' field under a new 'quantities' section.

Entity Relationship Diagram for YAML Schema Update

erDiagram
    SCHEMA {
        string nxdl
        string eln
        string quantities
    }
    SCHEMA ||--o{ TITLE : contains
    TITLE {
        string type
        string m_annotations
    }
Loading

File-Level Changes

Change Details Files
Restructured YAML schema by adding a new 'quantities' section
  • Added new 'quantities' parent section
  • Moved 'title' field under the 'quantities' section
src/pynxtools_xps/nomad/examples/xps.scheme.archive.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lukaspie - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Could you clarify the purpose of adding the empty 'quantities' field? It appears incomplete as there are no properties defined under it.
  • The CITATION.cff file appears in the diff but shows no changes - was this intended to be modified?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@lukaspie lukaspie merged commit 3df5dbf into main Dec 3, 2024
7 checks passed
@lukaspie lukaspie deleted the example-fix branch December 3, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant