add intitial version for jdx reader from thermo fischer #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaspie
reviewed
Dec 13, 2024
src/pynxtools_raman/reader.py
Outdated
| @@ -79,6 +80,77 @@ def handle_eln_file(self, file_path: str) -> Dict[str, Any]: | |||
|
|
|||
| return {} | |||
|
|
|||
|
|
|||
| def parse_jdx_file(self, filepath): | |||
There was a problem hiding this comment.
I suggest to move this to its own module (like the rod and witec readers) eventually.
There was a problem hiding this comment.
yes, was planned. Did not finish this yet.
|
I have updated the reader to include all meta data which was avialble in the jdx file. There are various other input formats, which have to be considered, as these most probably contain much more meta data. This should be testet with more different .jdx output files, but in principle it works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version to add a reader for the .jdx output file format from thermo fischer.
Most probably have to use another one, as this example does only contain minimal information.