Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return empty plots if data isn't available #95

Merged
merged 1 commit into from
May 14, 2024
Merged

Conversation

ka-sarthak
Copy link
Collaborator

Fixes the bug when XRD schema is initiated without a data file.

Current behavior: plotting methods are triggered even if data is not available, leading to errors

Fix: add checks for data availability before triggering plotting

@ka-sarthak ka-sarthak self-assigned this May 14, 2024
Copy link
Collaborator

@hampusnasstrom hampusnasstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ka-sarthak ka-sarthak merged commit f47f6fb into main May 14, 2024
1 check passed
@ka-sarthak ka-sarthak mentioned this pull request May 16, 2024
4 tasks
@ka-sarthak ka-sarthak deleted the hotfix_xrd_plots branch August 28, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants