Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing name of m_package to more specific one #45

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Changing name of m_package to more specific one #45

merged 2 commits into from
Nov 30, 2023

Conversation

ka-sarthak
Copy link
Collaborator

No description provided.

@ka-sarthak ka-sarthak requested a review from aalbino2 November 30, 2023 16:29
@ka-sarthak ka-sarthak linked an issue Nov 30, 2023 that may be closed by this pull request
Name of the m_package for XRD schema.py #44
Closed
aalbino2
aalbino2 requested changes Nov 30, 2023
View reviewed changes
src/nomad_measurements/xrd/schema.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

call it nomad-xrd, I think it is more concise

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ka-sarthak ka-sarthak merged commit 6bc1e4d into main Nov 30, 2023
@hampusnasstrom hampusnasstrom deleted the 44-name-of-the-m_package-for-xrd-schemapy branch December 8, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalbino2 aalbino2 aalbino2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Name of the m_package for XRD schema.py
2 participants
@ka-sarthak @aalbino2