114 looks for errors in the structlogger in tests #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyproject.toml
Outdated
| @@ -33,6 +33,7 @@ dev = [ | |||
| "pytest", | |||
| "ruff", | |||
| "structlog==22.3.0", | |||
| "nomad-lab[infrastructure]>=1.3.4dev", | |||
There was a problem hiding this comment.
Why do we need the infrastructure dependencies?
There was a problem hiding this comment.
Some of the dependencies from nomad are needed when running the cap log fixture, specifically:
"python-logstash==0.4.6",
"mongoengine>=0.20",
"pyjwt[crypto]==2.6.0",
"unidecode==1.3.2",
"fastapi==0.92.0",
"zipstream-new==1.1.5",Since all of them were mentioned in the infrastructure, I thought of adding the full set to avoid future import errors if a new dependency is added, which the cap log fixture might require. However, we can also list only the dependencies that are currently required.
ka-sarthak
force-pushed
the
114-looks-for-errors-in-the-structlogger-in-tests
branch
4 times, most recently
from
564ea06 to
b4b6696
Compare
ka-sarthak
force-pushed
the
114-looks-for-errors-in-the-structlogger-in-tests
branch
from
b4b6696 to
cfa9126
Compare
ka-sarthak
force-pushed
the
114-looks-for-errors-in-the-structlogger-in-tests
branch
from
1234047 to
bb71620
Compare
|
@hampusnasstrom I checked again if infra deps are still needed. Only one of them is required: To test the caplog fixture, you can log an error in the normalize method. This should make the pytest fail. For example, adding this: logger.error('Error: here for testing')here: |
ka-sarthak
force-pushed
the
114-looks-for-errors-in-the-structlogger-in-tests
branch
from
1504c10 to
140ab7a
Compare
ka-sarthak
force-pushed
the
114-looks-for-errors-in-the-structlogger-in-tests
branch
from
140ab7a to
e5592f2
Compare
ka-sarthak
deleted the
114-looks-for-errors-in-the-structlogger-in-tests
branch
aalbino2
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Add fixture to capture error from logs * Add nomad-lab infrastructure deps required by caplog fixture * Ruff * Refactoring fixtures; parameterize caplog to allow capturing different log levels * Removing the formatter from nomad.utils * testing: add logger.error in normalize * testing: adding the formatter from nomad.utils * Add logstash dep; cleaning * Cleaning * Specify caplog as an arg (from review)
aalbino2
added a commit
that referenced
this pull request
Dec 19, 2024
* Added general PPMS plugin in its old structure * Adapted PPMS structure * Quick fix on the entry points * Fix in schema bound_logger import * Fixed formatting * Fixed some typos * Small Fix: ACT -> ETO * changed names and made test folder * added entrydata_definition for parser specilization * lint * Changed repeats to not is_scalar in merge_sections (#136) Updated `merge_sections` util function to work with the latest nomad-lab version * 137 merge sections break for non scalar quantities (#138) * Added breaking test for boolean array * Added more breaking test cases * Added fix for comparing non numpy arrays * Ruff * Enhance test_merge_sections to capture output and validate float_array values * Refine warning message for merging sections with differing quantity values * Refactor merge_sections to improve warning logic for differing quantity values * 139 merge sections still breaking for pint quantity arrays (#140) * Added breaking test for float array with units * Added fix for comparison of pint quantity arrays * Added test for multi dimensional array * Ruff * 114 looks for errors in the structlogger in tests (#115) * Add fixture to capture error from logs * Add nomad-lab infrastructure deps required by caplog fixture * Ruff * Refactoring fixtures; parameterize caplog to allow capturing different log levels * Removing the formatter from nomad.utils * testing: add logger.error in normalize * testing: adding the formatter from nomad.utils * Add logstash dep; cleaning * Cleaning * Specify caplog as an arg (from review) * moved nomad search import * lint * change create_archive inheritance * lint * fix test files path * Added ETO test file to tests/ppms * Added ETO sequence file to tests/ppms * Changed regex in parsers mainfile_name_re * Removed entry_type from PPMSSequenceParser * lint * Fixed PPMS parsers Added call of set_entrydata_definition to parse * Added test for PPMS data file * Update __init__.py * Fixed failing ppms test * Fixed ppms test again * PPMS data parser now matches two mime types --------- Co-authored-by: Andrea Albino <andrea.albino@physik.hu-berlin.de> Co-authored-by: Hampus Näsström <hampus.nasstrom@gmail.com> Co-authored-by: Sarthak Kapoor <57119427+ka-sarthak@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #114