Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github.io changelog: increase the font-weight of the level 1 heading #6392

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

Basilisk3
Copy link
Collaborator

@Basilisk3 Basilisk3 commented Aug 4, 2024

Description of the proposed changes

As per the title. Currently, h2 has a higher weight than h1, which looks a bit odd.

Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested by modifying using inspect element.
Before:
image

After:
image

@lL1l1 lL1l1 merged commit 0a94e1c into FAForever:develop Sep 4, 2024
4 checks passed
@Basilisk3 Basilisk3 deleted the h1weight branch September 5, 2024 12:11
@Basilisk3
Copy link
Collaborator Author

Looks like this change is overridden in base.scss.

Replacing the code added in this PR with the code below could fix this, but since it is not possible to test changes to the .scss via inspect element, I cannot be sure.

.custom-container h1,
.custom-container .text-alpha {
  font-weight: 600;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants