Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : Update docs-build to include PR link rewrites #6391

Merged
merged 10 commits into from
Aug 5, 2024

Conversation

relent0r
Copy link
Contributor

@relent0r relent0r commented Aug 4, 2024

Closes #6376

This PR updates the docs-build.yml workflow to update md files that include PR references.

It will loop through all files in the
docs/patches
docs/_posts

directories and rewrite any PR references using the #xxxxx expression and add the PR link.

The script takes 4 parameters. This is so it can be used with other repositories / environments in the future.
FOLDER_NAME - Where the md files are located
ORG_NAME - The github org name
REPO_NAME - The repository name
BASE_HOSTNAME - github.com

@relent0r
Copy link
Contributor Author

relent0r commented Aug 4, 2024

@Garanas do we include snippets for these sorts of PRs?

@Garanas
Copy link
Member

Garanas commented Aug 4, 2024

Not yet - when it is in a releasable state then we'll create a snippet about it.

@Garanas
Copy link
Member

Garanas commented Aug 4, 2024

Can you add a (MIT) license to the file?

Copy link
Member

@Garanas Garanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested it locally by running the bash script directly - appears to be all good!

@relent0r relent0r merged commit cdf8162 into FAForever:develop Aug 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace #XYZW with a link to the pull request in question
2 participants