Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix definition of flake overlays output #80

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

adrian-gierakowski
Copy link
Contributor

overlays should not be defined per-system (see: https://discourse.nixos.org/t/how-to-consume-a-eachdefaultsystem-flake-overlay/19420/3)
also, overlay (singular) is not an official output
so we keep overlays.default only

I'm working on a project which doesn't use flakes yet so prefer to consume
via an overlay :)

overlays should not be defined per-system (see: https://discourse.nixos.org/t/how-to-consume-a-eachdefaultsystem-flake-overlay/19420/3)
also, overlay (singular) is not an official output
so we keep overlays.default only
@F1bonacc1
Copy link
Owner

Thanks again @adrian-gierakowski
@thenonameguy was taking care of this code. Probably everything is OK, but if you want another pair of eyes, it's better to be his 😄

Copy link
Contributor

@thenonameguy thenonameguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch 👍

@F1bonacc1 F1bonacc1 merged commit efe35fd into F1bonacc1:main Jul 21, 2023
@adrian-gierakowski
Copy link
Contributor Author

Thanks!

@mikeland73
Copy link

I think this breaks flake support.

Previously:

nix search github:F1bonacc1/process-compose/v0.43.1 --json
{"packages.aarch64-darwin.process-compose":{"description":"A simple and flexible scheduler and orchestrator to manage non-containerized applications","pname":"process-compose","version":"0.43.1"}}

But now:

nix search github:F1bonacc1/process-compose --json
{}

nix profile install github:F1bonacc1/process-compose/v0.43.1

works fine, but

nix profile install github:F1bonacc1/process-compose
error: cached failure of attribute 'defaultPackage.aarch64-darwin'

fails

@thenonameguy
Copy link
Contributor

Sorry for the breakage, fixing.

@mikeland73
Copy link

@thenonameguy thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants