Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump github.com/rivo/tview from v0.0.0-20240307173318-e804876934a1 to v0.0.0-20240505185119-ed116790de0f #187

Closed
wants to merge 1 commit into from

Conversation

shivaraj-bh
Copy link
Contributor

This version includes rivo/tview#959, which resolves #186.

… v0.0.0-20240505185119-ed116790de0f

This version includes rivo/tview#959, which resolves F1bonacc1#186
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@F1bonacc1
Copy link
Owner

Hey @shivaraj-bh,

Thanks for finding the solution so quickly!
Unfortunately, this version breaks the F1 shortcuts view.
Can you confirm that this is the case for you as well?

Previous version:
image

New version:
image

@F1bonacc1
Copy link
Owner

I think I found a workaround for the dialog issue.

@shivaraj-bh
Copy link
Contributor Author

Unfortunately, this version breaks the F1 shortcuts view.

That’s right, it does

@shivaraj-bh
Copy link
Contributor Author

Screenshot 2024-05-17 at 10 14 46 PM

It seems to not collapse when the Close button is not there

@shivaraj-bh
Copy link
Contributor Author

shivaraj-bh commented May 17, 2024

It is not to do with the button. Anytime there is more than one item, the dialog collapses and transforms into a fixed-size dialog at the top center.

Edit: perhaps a bug in upstream? I don’t see any existing open issue though

@shivaraj-bh
Copy link
Contributor Author

Fixed in 8877e7f

@shivaraj-bh shivaraj-bh deleted the bump-tview branch May 18, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process-compose crashes when clicking the horizontal divider
2 participants