Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support a few more styling options #182

Merged
merged 1 commit into from
May 6, 2024

Conversation

cdmistman
Copy link
Contributor

some of the styling options weren't changing as i'd expected them to. i added 2 new styling fields contrastBgColor and attentionBgColor and assigned them to the theme styling's ContrastBgColor and MoreContrastBgColor fields, respectively.

I also updated all of the existing themes' options to reflect their existing values before this change. I couldn't find any elements that changed colors with these patched fields

@cdmistman cdmistman force-pushed the some-styling-options branch from 39062f8 to a453eae Compare May 5, 2024 23:52
Copy link

sonarqubecloud bot commented May 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@F1bonacc1
Copy link
Owner

That's great @cdmistman!

Thanks for the PR!
In which situations those colors are used?
I fetched the PR, but I can't find the difference 😄

@cdmistman
Copy link
Contributor Author

the components i was trying to style:

  • the "quit" dialog (contrastBgColor)
  • the background colors in the other dialogs (ie in the search dialog - also contrastBgColor)
  • the Shutting down... text (afaict the only element that uses the new attentionBgColor)

@cdmistman
Copy link
Contributor Author

I fetched the PR, but I can't find the difference 😄

that's what i was hoping! opt-in styling changes that nobody will notice but silently expands more theming options :)

might be good for somebody to also update the builtin themes with better-chosen values for these options, but in the meantime as long as nothing changes i think it's ok :)

should also be api-compatible on the patch level (ie, 1.2.1 release) since user themes inherit from the default theme

@F1bonacc1
Copy link
Owner

Got it, thanks.
That looks great.

Agree with your second point. Now that the theming engine is here, given how easy it is to add and edit themes, the idea is to have at least as many themes as KDE Konsole 😄

@F1bonacc1 F1bonacc1 merged commit f8c25b9 into F1bonacc1:main May 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants