move setInputCapture to mainGrid, except ctrl+c #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when you open the find Dialog, pressing escape to close it does not work. First.
First, i tried checking if a
DialogPage
existed, and if it does, close it. I added this in theActionLogFindExit
, but this closing of the dialog page is not always connected toEsc
is the keybinding is changed. So it needed an extra check for that. This didn't feel right to me.Thinking about it, it felt odd the escape never reached the PageDialog even though that page has focus. It seems that's because all the keybindings are captures in the
appView
. This always goes first, before any active page.So I moved this mapping to the
mainGrid
page. This caused Control+C to not be captures. So i moved just this keybinding so the appView.This allows the PageDialog to handle Escape before it's send to the mainGrid. Which allows the search dialog to close itself on escape.
I tried to make sure all keybindings still work, and as far as i can tell they do.