-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fails to run in docker because user is nil #84
Comments
when in docker use other thing |
|
I guess you built you images with nix? You should use fakeNss or shadowSetup. There are many programs out there which will fail without it. |
![image](https://github.com/ComposableFi/composable/assets/757125/1f288499-3285-438b-9499-68847851b52e) Required for merge: - [ ] `pr-workflow-check / draft-release-check` is ✅ success - Other rules GitHub shows you, or can be read in [configuration](../terraform/github.com/branches.tf) Makes review faster: - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [ ] I marked PR by `misc` label if it should not be in release notes - [x] Linked Zenhub/Github/Slack/etc reference if one exists F1bonacc1/process-compose#84 - [ ] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [ ] Added reviewer into `Reviewers` - [x] I tagged(`@`) or used other form of notification of one person who I think can handle best review of this PR - [ ] I have proved that PR has no general regressions of relevant features and processes required to release into production - [ ] Any dependency updates made, was done according guides from relevant dependency - Clicking all checkboxes - Adding detailed description of changes when it feels appropriate (for example when PR is big)
yeah, fixed liked that. but process compose is ideal with nix as nix already decent isolation, just need some decent process manager working slick out of box. |
Great response @adrian-gierakowski. This is not a bug in process-compose, it's fair to assume for the common usecases that nss will be set up. IMO this should be closed. |
@thenonameguy for this exact case, user name is used only to setup logging file name.
not sure if this is really blocker to not use user and make nix use cases simpler. if there was more complicated use, like some security setting or like, sure, but in this case it is not needed to be like that. fix also could be set but seems fix is just if no user than %s for user would be empty string because no user |
I see, fair point. I guess a fallback to the stringified PID of the process-compose process itself would be preferable. Since that would not be a breakage and still keep some form of isolation between concurrently running process-compose instances, it would be a fine relaxation of the runtime environment dependencies. |
…espace (#4016) ![image](https://github.com/ComposableFi/composable/assets/757125/1f288499-3285-438b-9499-68847851b52e) Required for merge: - [x] `pr-workflow-check / draft-release-check` is ✅ success - Other rules GitHub shows you, or can be read in [configuration](../terraform/github.com/branches.tf) Makes review faster: - [x] PR title is my best effort to provide summary of changes and has clear text to be part of release notes - [x] I marked PR by `misc` label if it should not be in release notes - [x] Linked Zenhub/Github/Slack/etc reference if one exists F1bonacc1/process-compose#84 - [x] I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description - [x] Added reviewer into `Reviewers` - [x] I tagged(`@`) or used other form of notification of one person who I think can handle best review of this PR - [x] I have proved that PR has no general regressions of relevant features and processes required to release into production - [x] Any dependency updates made, was done according guides from relevant dependency - Clicking all checkboxes - Adding detailed description of changes when it feels appropriate (for example when PR is big)
fix is simple, so it would take me hours to catch up with the thing because i am not go dev. will donate 50 usd in crypto to project for fix. btw another nice use case why nix/guix/(partially will work on win/mac sandboxes so) may be target nieche for product #87 |
Hi, Sorry for the late response. I was away for some time.
|
most complex fix to use specific mod to detect user on non posix compliant systems. i guess go has one. so it will detect root in this case. in docker afaik there is USER env set usually, try it may be too. it seems set without shadow. https://unix.stackexchange.com/questions/76354/who-sets-user-and-username-environment-variables/76356 empty string will work great too. i guess most automated way will work. |
what would happen in case of conflict using same file? new PC will fail to start? can add root process id as suffix for any files created as part of run? |
Will be fixed in the next release. |
Since Process Compose opens a port, without changing the default one, 2 instances of PC won't run. In other cases where you need to run 2 instances in the same environment, I suggest using the |
Fixed in v0.65.1 |
Defect
Make sure that these boxes are checked before submitting your issue -- thank you!
process-compose info
)Version of
process-compose
:OS environment:
Docker.
Steps or code to reproduce the issue:
Expected result:
Runs or other error.
Actual result:
The text was updated successfully, but these errors were encountered: