Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warn about impossible conditions #153

Closed
teto opened this issue Mar 7, 2024 · 3 comments
Closed

warn about impossible conditions #153

teto opened this issue Mar 7, 2024 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@teto
Copy link

teto commented Mar 7, 2024

Feature Request

warn if conditions can not be satisfied
Out of curiosity I added the following condition to a process (e.g, waiting for postgres to be up) wihout setting up a healthprobe on postgresql.

    depends_on:
      postgresql:
        condition: process_healthy

so it turns out that my process with never start.

Use Case:

avoid mistake/help the user write his configuration

Proposed Change:

It might be useful to add a warning in that case (in F3, the process details) or instead of pending mark as "Impossible". In the logs at least.

Who Benefits From The Change(s)?

users

@teto
Copy link
Author

teto commented Mar 7, 2024

On a related note, the doc says:

process_healthy - is the type for waiting until a process is healthy

does is mean ready & alive ? just ready ? Could be nice to explicit. It's maybe obvious for kubernetes administrators and as a basic kube user it's not obvious yet. Seems like in my tests it was the "ready" probe. In which case it could be called "process_ready" ?

@F1bonacc1
Copy link
Owner

Hey @teto,

Thanks for all the improvement recommendations.
I will add a better warning to the next release.

@F1bonacc1 F1bonacc1 added enhancement New feature or request good first issue Good for newcomers labels Mar 7, 2024
@F1bonacc1
Copy link
Owner

Added in v1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants