Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expan log section instead of processes with a bigger window #132

Closed
domenkozar opened this issue Jan 29, 2024 · 9 comments
Closed

Expan log section instead of processes with a bigger window #132

domenkozar opened this issue Jan 29, 2024 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@domenkozar
Copy link

Currently if you make the window bigger with TUI, it will expand the process list even when there are no more processes.

Instead it could detect how many processes are and start extending logs section when all processes are shown.

@F1bonacc1
Copy link
Owner

Hey @domenkozar,

Sounds like a good idea.
The processes portion will have to be dynamic since the user can change the amount of running processes, on the fly.
Maybe instead of doing it automatically, it will be better to introduce a shortcut to control the split location. What do you think?

@F1bonacc1 F1bonacc1 added enhancement New feature or request good first issue Good for newcomers labels Jan 29, 2024
@thenonameguy
Copy link
Contributor

Automatic layouting would be preferred IMO. Should be simple to follow when the list of processes expand.

Otherwise, in Doom Emacs the keybinding to increase/decrease the currently focused "pane" height is C-w +/- respectively.

@domenkozar
Copy link
Author

If automaticaly layout can be implemented, then I think no user action is needed, which is what I'd prefer :)

@F1bonacc1
Copy link
Owner

F1bonacc1 commented Jan 30, 2024

Should the automatic layout grow above 50%?
What do you think should be the max % if yes?
What should be the min %?

It can also be expressed as # of processes.

@domenkozar
Copy link
Author

I'd say that the max for the process pane is # processes + 1.

@F1bonacc1
Copy link
Owner

There are many situations where the # processes is higher than what is visible in a single screen.

@thenonameguy
Copy link
Contributor

thenonameguy commented Jan 30, 2024

Min = line-height * (total process count + 1 (padding))
Max = 50% sounds like a good starting point, for my use-cases if I'm in split view, I care mainly about the currently selected process logs, so scrolling the process list is okay.
If I want a holistic view of all processes I would fullscreen that pane.

There are many situations where the # processes is higher than what is visible in a single screen.

Example from #133 (emphasis mine):

I love the feature introduced in #123. However, in one of the projects I use process-compose, there are around 200 processes.

@F1bonacc1
Copy link
Owner

Thanks (as always) @thenonameguy
Can I rephrase it as:

  • Min - 2 processes
  • Auto - line-height * (total process count + 1 (padding))
  • Max - 50% screen size

@F1bonacc1
Copy link
Owner

Added in v0.85.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants