Highlight crashed processes in red

[srid]

Feature Request

If a process exits with non-zero exit code, highlight that process line in RED colour or something. This catches the user's attention more readily than when they have to linearly (O(n)) scan the "EXIT CODE" column manually.

Use Case:

In the setup below, both the pg-basebackup-* processes exited unsuccessfully. (How quickly can your eyes land on them?)

Proposed Change

Highlight the pg-basebackup-* processes in different colour (red) to visually indicate that they crashed.

Who Benefits From The Change(s)?

Everyone, especially those who use process-compose to run more than a handful of processes.

Alternative Approaches

None that I can think of.

[srid]

Implementation tip:

process-compose/src/tui/proc-table.go

Line 37 in 24238b4

pv.procTable.SetCell(r+1, 7, tview.NewTableCell(strconv.Itoa(state.ExitCode)).SetAlign(tview.AlignRight).SetExpansion(0).SetTextColor(tcell.ColorLightSkyBlue))

[F1bonacc1]

Great! I will add it to the next release.

While I am at it, do you have any recommendations for additional color based hints for other states, like completed and pending?

[stijnveenman]

This is also something I've recently thought about since we had a similar need.

One thing I personally would like to see is a status icon column (for example with just the ASCII char ●) and giving that a color, instead of highlighting the entire row. This might improve accessibility/readability on colors.

For me, i'd like to see the following colors:

• pending: gray
• completed with exit code: 0: green
• non exit code 0: red
• running: blue
• unhealthy: yellow

[F1bonacc1]

@stijnveenman I like your suggestion!
Considering color-blind people, maybe it will be better also to use a unique icon for each state?
Something like this:

[F1bonacc1]

Added in v0.80.0
@stijnveenman I implemented your initial suggestion - it looks cleaner to me.
The lack of uniformity between the icon (ASCII chars) styles bugged my OCD too much :)
As for the color-blind people, the state can be inferred from the text as well.

[srid]

@F1bonacc1 Nice!

This is what it looks like, btw.

• I'm curious why 'skipped' is in yellow. Yellow makes sense for 'not ready' as a warning state. Is skipped a warning state?

[F1bonacc1]

Hi @srid,
I am always open to feedback; if something can be improved, I am all for it.
Skipped means one of the 2 failed states:

1. Process A waited for B to finish with exit code 0, but it didn't.
2. Process A waited for B to become ready but B finished without becoming ready.