feat #199: stopping multiple procs will not fail fast

src/api/pc_api.go

@@ -141,7 +141,11 @@ func (api *PcApi) StopProcesses(c *gin.Context) {
 	}
 	stopped, err := api.project.StopProcesses(names)
 	if err != nil {
-		c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+		if len(stopped) == 0 {
+			c.JSON(http.StatusBadRequest, gin.H{"error": err.Error()})
+		} else {
+			c.JSON(http.StatusMultiStatus, stopped)
+		}
 		return
 	}
 

src/app/project_runner.go

@@ -288,18 +288,23 @@ func (p *ProjectRunner) StopProcess(name string) error {
 	if err != nil {
 		log.Err(err).Msgf("failed to stop process %s", name)
 	}
-	return nil
+	return err
 }
 
 func (p *ProjectRunner) StopProcesses(names []string) ([]string, error) {
 	stopped := make([]string, 0)
 	for _, name := range names {
 		if err := p.StopProcess(name); err == nil {
 			stopped = append(stopped, name)
-		} else {
-			return nil, err
 		}
 	}
+
+	if len(stopped) != len(names) {
+		if len(stopped) == 0 {
+			return stopped, fmt.Errorf("no such processes or not running: %v", names)
+		}
+		return stopped, fmt.Errorf("failed to stop some processes")
+	}
 	return stopped, nil
 }
 

src/client/stop.go

@@ -47,7 +47,7 @@ func (p *PcClient) stopProcesses(names []string) ([]string, error) {
 		return nil, err
 	}
 	defer resp.Body.Close()
-	if resp.StatusCode == http.StatusOK {
+	if resp.StatusCode == http.StatusOK || resp.StatusCode == http.StatusMultiStatus {
 		stopped := []string{}
 		if err = json.NewDecoder(resp.Body).Decode(&stopped); err != nil {
 			log.Err(err).Msgf("failed to decode stop processes %v", names)

src/cmd/stop.go

@@ -2,23 +2,62 @@ package cmd
 
 import (
 	"fmt"
+	"github.com/fatih/color"
 	"github.com/rs/zerolog/log"
 	"github.com/spf13/cobra"
+	"os"
+	"strings"
+)
+
+var (
+	verboseOutput = false
 )
 
 // stopCmd represents the stop command
 var stopCmd = &cobra.Command{
 	Use:   "stop [PROCESS...]",
-	Short: "Stop a running process",
+	Short: "Stop running processes",
+	Args:  cobra.MinimumNArgs(1),
 	Run: func(cmd *cobra.Command, args []string) {
 		stopped, err := getClient().StopProcesses(args)
 		if err != nil {
 			log.Fatal().Err(err).Msgf("failed to stop processes %v", args)
 		}
-		fmt.Printf("Processes %v stopped\n", stopped)
+		missing := findMissingProcesses(args, stopped)
+		if len(missing) != 0 && !verboseOutput {
+			fmt.Printf("Successfully stopped some processes but encountered failures for: %s\n",
+				"'"+strings.Join(missing, `', '`)+`'`)
+			os.Exit(1)
+		}
+		for _, name := range stopped {
+			fmt.Printf("%s Successfully stopped %s\n", color.GreenString("✓"), name)
+		}
+		if len(missing) > 0 {
+			log.Error().Msgf("failed to stop some processes: %v", missing)
+			for _, name := range missing {
+				fmt.Printf("%s Failed to stop %s\n", color.RedString("✘"), name)
+			}
+			os.Exit(1)
+		}
 	},
 }
 
+func findMissingProcesses(requested, stopped []string) []string {
+	bMap := make(map[string]bool)
+	for _, str := range stopped {
+		bMap[str] = true
+	}
+
+	missing := []string{}
+	for _, str := range requested {
+		if !bMap[str] {
+			missing = append(missing, str)
+		}
+	}
+	return missing
+}
+
 func init() {
 	processCmd.AddCommand(stopCmd)
+	stopCmd.Flags().BoolVarP(&verboseOutput, "verbose", "v", verboseOutput, "verbose output")
 }