refactor: split InsightsDataSource class methods

EzzalddeenAli · Mar 2, 2024 · e9a9339 · e9a9339
1 parent 20f407a
commit e9a9339
Show file tree

Hide file tree

Showing 3 changed files with 147 additions and 183 deletions.
diff --git a/frontend/src/query/NativeQueryEditor.vue b/frontend/src/query/NativeQueryEditor.vue
@@ -10,10 +10,12 @@ const props = defineProps({
 
 const query = inject('query')
 if (query.doc.data_source) {
-	call('insights.api.data_sources.get_source_schema', {
-		data_source: query.doc.data_source,
+	call('run_doc_method', {
+		method: 'get_schema',
+		dt: 'Insights Data Source',
+		dn: query.doc.data_source,
 	}).then((response) => {
-		query.sourceSchema = response
+		query.sourceSchema = response.message
 	})
 }
 const completions = computed(() => {

diff --git a/insights/api/data_sources.py b/insights/api/data_sources.py
@@ -228,11 +228,6 @@ def fetch_column_values(data_source, table, column, search_text=None):
     return doc.get_column_options(table, column, search_text)
 
 
-@frappe.whitelist()
-def get_source_schema(data_source):
-    return frappe.get_doc("Insights Data Source", data_source).get_schema()
-
-
 @frappe.whitelist()
 def get_relation(data_source, table_one, table_two):
     table_one_doc = InsightsTable.get_doc({"data_source": data_source, "table": table_one})