fix: navigating back and forth breaks reactivity

EzzalddeenAli · Jan 22, 2024 · 24f72db · 24f72db
1 parent 0d19641
commit 24f72db
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 19 deletions.
diff --git a/frontend/src/query/resources/useQuery.js b/frontend/src/query/resources/useQuery.js
@@ -13,16 +13,7 @@ import useQueryResults from './useQueryResults'
 
 const session = sessionStore()
 
-const queries = {}
-
 export default function useQuery(name) {
-	if (!queries[name]) {
-		queries[name] = makeQuery(name)
-	}
-	return queries[name]
-}
-
-function makeQuery(name) {
 	const resource = useQueryResource(name)
 	const state = reactive({
 		loading: true,

diff --git a/frontend/src/query/resources/useQueryResults.js b/frontend/src/query/resources/useQueryResults.js
@@ -3,16 +3,7 @@ import { createDocumentResource } from 'frappe-ui'
 import { computed, reactive } from 'vue'
 import { getFormattedResult } from '@/utils/query/results'
 
-const queryResults = {}
-
-export default function useQueryResults(name) {
-	if (!queryResults[name]) {
-		queryResults[name] = makeQueryResults(name)
-	}
-	return queryResults[name]
-}
-
-function makeQueryResults(result_name) {
+export default function useQueryResults(result_name) {
 	const resource = getResultResource(result_name)
 	resource.get.fetch()
 	return reactive({