Merge pull request frappe#217 from ankush/fix_perm_hook

fix: perm hooks should always send true/false
EzzalddeenAli · Jan 31, 2024 · 1d5ceb3 · 1d5ceb3
2 parents b79350a + 5180405
commit 1d5ceb3
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/insights/overrides.py b/insights/overrides.py
@@ -16,11 +16,11 @@ def has_permission(doc, ptype, user):
         "Insights Query",
         "Insights Dashboard",
     ]:
-        return
+        return True
 
     # only check if doc exists
     if not doc.name:
-        return
+        return True
 
     if not frappe.db.get_single_value("Insights Settings", "enable_permissions"):
         return True