Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/pid filter tool #19

Merged
merged 8 commits into from
Feb 2, 2024
Merged

Feat/pid filter tool #19

merged 8 commits into from
Feb 2, 2024

Conversation

Wkkkkk
Copy link
Collaborator

@Wkkkkk Wkkkkk commented Jan 25, 2024

No description provided.

@Wkkkkk Wkkkkk linked an issue Jan 25, 2024 that may be closed by this pull request
Make new PID filter tool #8
Closed
@Wkkkkk Wkkkkk requested a review from tobbee January 25, 2024 14:56
tobbee
tobbee reviewed Jan 26, 2024
View reviewed changes
Copy link
Collaborator

@tobbee tobbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have a new tool.

I'd like to see the following extra things:

  1. List of all PIDs and number of packets per pid if given no drop
  2. Specify drop pids instead of keep pids
  3. Make it possible to pipe to stdout (only TS packets).

cmd/mp2ts-pidfilter/main.go Outdated Show resolved Hide resolved
cmd/mp2ts-pidfilter/main.go Outdated Show resolved Hide resolved
internal/parser.go Outdated Show resolved Hide resolved
internal/parser.go Outdated Show resolved Hide resolved
cmd/mp2ts-pidfilter/main.go Outdated Show resolved Hide resolved
@Wkkkkk Wkkkkk requested a review from tobbee January 26, 2024 16:48
tobbee
tobbee reviewed Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@tobbee tobbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is mostly fine, but the writer parameter names are confusing and there are some minor spelling mistakes.

cmd/mp2ts-pidfilter/main.go Outdated Show resolved Hide resolved
cmd/mp2ts-pidfilter/main.go Outdated Show resolved Hide resolved
cmd/mp2ts-pidfilter/main.go Outdated Show resolved Hide resolved
internal/utils.go Outdated Show resolved Hide resolved
internal/parser.go Outdated Show resolved Hide resolved
internal/utils.go Outdated Show resolved Hide resolved
@Wkkkkk Wkkkkk merged commit 1b2c5c3 into main Feb 2, 2024
4 checks passed
@Wkkkkk Wkkkkk deleted the Feat/Pid-filter-tool branch February 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobbee tobbee tobbee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make new PID filter tool
2 participants
@Wkkkkk @tobbee