Moved query of log file content to GraphQL #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurgelenas
requested changes
Jun 25, 2023
…e. Refactored based on the review comments.
jurgelenas
requested changes
Jun 26, 2023
jurgelenas
requested changes
Jun 27, 2023
jurgelenas
requested changes
Jun 28, 2023
|
I also get a horizontal scrollbar when the app is in the default size:
|
jurgelenas
requested changes
Jun 28, 2023
…omponents.Fixed scrolling issue.Converted logger query to use promise.
|
@vbotnaru can you resolve the merge conflicts? |
|
While testing out the PR I encountered a crash when trying to view the logs after performing a build. This error can be reproduced by performing a WIFI build for any device and then switching to the logs view.
|
Fixed. One of the values was null and typeof null === 'object' in js. Shame on me i forgot this :/ |
jurgelenas
approved these changes
Oct 4, 2023
|
Requesting final review from @justinlampley. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.