Rename HappyModel EP to EP1/2 #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about 1&2 instead of 1/2, since it looks a lot like .5? |
|
I just matched what already exists in the ExpressLRS main repo, and what the Radiomaster RP1/2 has (in both repos). Is there really any chance someone could think it is the target for a product called the EP0.5? 😆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had someone ask me what target to use for their EP2 receiver and said they couldn't find it in the configurator. This renames "HappyModel EP 2400 RX" to "HappyModel EP1/2 2400 RX" to help with identification and match what is in the ELRS targets.json. It also could help someone with an "EP1 Dual" who might think "EP" is close enough? Probably not?