Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Categorize HDZero Goggle VRX Backpack as "Goggles" #484

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

Wikiwix
Copy link
Contributor

@Wikiwix Wikiwix commented Mar 14, 2023

With there already being a category for Goggles (containing the Orqa FPV.Connect ESP Backpack) this target should be moved there as well.

With there already being a category for `Goggles` (containing the `Orqa FPV.Connect ESP Backpack`) this target should be moved there as well
@rumpelst1lzk1n
Copy link

I offer a different perspective:
The HDZero goggles come with an integrated VRX for the HDZero system. The integrated ESP backpack works with this VRX and to my knowledge with this VRX only. Additional VRXs (e.g. attached via HDMI or the analog bay) require their own ESP backpack. As the backpack works only for the integrated VRX, one could argue that the category VRX is ok.

@Wikiwix
Copy link
Contributor Author

Wikiwix commented Mar 15, 2023

@rumpelst1lzk1n based on https://github.com/pkendall64/hdzero-goggle/wiki/Analog-Module-Backpack-Control I believe that this is not correct. (The Recording control already works with analogue, does it not?

In any case I believe that this technicality does not matter from a UX point of view:

For an end user who wants to flash Backpack to his HDZero Goggles, they will choose Goggles as category – not VRX.

@justinlampley
Copy link
Collaborator

@pkendall64 What do you think moving the HDZero Goggle VRX Backpack to the Goggles category?

@pkendall64
Copy link
Contributor

@pkendall64 What do you think moving the HDZero Goggle VRX Backpack to the Goggles category?

I'm ok with that.

@justinlampley justinlampley merged commit 745a287 into ExpressLRS:master Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants